Closed Bug 1772378 Opened 2 years ago Closed 2 years ago

eval is still allowed in JSMs

Categories

(Core :: DOM: Security, defect, P2)

Product:
Core
Component:
DOM: Security
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(2 files)

Bug 1772378: Move Eval checks higher to encompass JSMs r?bholley
(deleted), text/x-phabricator-request
Details
Bug 1772378: Add test exemptions for expanded eval restrictions r?jdescottes
(deleted), text/x-phabricator-request
Details

Some investigation showed that calls to eval() are still allowed in .jsm files; because they don't have a CSP attached to them.

For the initial testcase I used to confirm this, the execution flow was:

  1. EvalKernel
  2. JSContext::isRuntimeCodeGenEnabled
  3. nsScriptSecurityManager::ContentSecurityPolicyPermitsJSAction
  4. (within that function) enter into if (!csp) here
  5. then return true here

We would like to be checking with nsContentSecurityUtils::IsEvalAllowed - this check does not depend on any CSP and should be orthogonal to it entirely.

Assignee: nobody → tom
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Attachment #9279446 - Attachment description: WIP: Bug 1772378: Move Eval checks higher to encompass JSMs → Bug 1772378: Move Eval checks higher to encompass JSMs r?bholley
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6085e9770cde Move Eval checks higher to encompass JSMs r=bholley

Backed out for causing xpcshell crashes.

[task 2022-06-27T18:27:16.824Z] 18:27:16  WARNING -  PROCESS-CRASH | xpcshell.ini:dom/indexedDB/test/unit/test_wasm_put_get_values.js | application crashed [@ nsTAutoJSString<char16_t>::init(JSContext*, JSString*)]
[task 2022-06-27T18:27:16.824Z] 18:27:16     INFO -  Crash dump filename: /tmp/xpc-other-haps5ld8/6fb6a98a-a3ae-8879-8b22-202662d25814.dmp
[task 2022-06-27T18:27:16.825Z] 18:27:16     INFO -  Operating system: Linux
[task 2022-06-27T18:27:16.825Z] 18:27:16     INFO -                    4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018
[task 2022-06-27T18:27:16.826Z] 18:27:16     INFO -  CPU: amd64
[task 2022-06-27T18:27:16.826Z] 18:27:16     INFO -       family 6 model 85 stepping 7
[task 2022-06-27T18:27:16.826Z] 18:27:16     INFO -       2 CPUs
[task 2022-06-27T18:27:16.827Z] 18:27:16     INFO -  Linux Ubuntu 18.04 - bionic (Ubuntu 18.04.6 LTS)
[task 2022-06-27T18:27:16.827Z] 18:27:16     INFO -  Crash reason:  SIGSEGV / SEGV_MAPERR
[task 2022-06-27T18:27:16.828Z] 18:27:16     INFO -  Crash address: 0x0
[task 2022-06-27T18:27:16.828Z] 18:27:16     INFO -  Process uptime: not available
[task 2022-06-27T18:27:16.829Z] 18:27:16     INFO -  Thread 0 xpcshell (crashed)
[task 2022-06-27T18:27:16.829Z] 18:27:16     INFO -   0  libxul.so!nsTAutoJSString<char16_t>::init(JSContext*, JSString*) [nsJSUtils.h:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 207 + 0x0]
[task 2022-06-27T18:27:16.829Z] 18:27:16     INFO -       rax = 0x0000000000000001    rdx = 0x0000000000000000
[task 2022-06-27T18:27:16.830Z] 18:27:16     INFO -       rcx = 0x0000000000000003    rbx = 0x00007ffc69d8a94c
[task 2022-06-27T18:27:16.830Z] 18:27:16     INFO -       rsi = 0x00007f2c8cc2f400    rdi = 0x00007ffc69d8a938
[task 2022-06-27T18:27:16.830Z] 18:27:16     INFO -       rbp = 0x00007ffc69d8a820    rsp = 0x00007ffc69d8a800
[task 2022-06-27T18:27:16.831Z] 18:27:16     INFO -        r8 = 0x0000000000000003     r9 = 0x00007ffc69d8afa0
[task 2022-06-27T18:27:16.831Z] 18:27:16     INFO -       r10 = 0x00007f2c8be4c300    r11 = 0x0000000000000005
[task 2022-06-27T18:27:16.831Z] 18:27:16     INFO -       r12 = 0x00007f2c8cc2f400    r13 = 0x00007ffc69d8a938
[task 2022-06-27T18:27:16.832Z] 18:27:16     INFO -       r14 = 0x00007ffc69d8a938    r15 = 0x0000000000000000
[task 2022-06-27T18:27:16.832Z] 18:27:16     INFO -       rip = 0x00007f2c9eb6b50a
[task 2022-06-27T18:27:16.832Z] 18:27:16     INFO -      Found by: given as instruction pointer in context
[task 2022-06-27T18:27:16.833Z] 18:27:16     INFO -   1  libxul.so!nsScriptSecurityManager::ContentSecurityPolicyPermitsJSAction(JSContext*, JS::RuntimeCode, JS::Handle<JSString*>) [nsScriptSecurityManager.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 465 + 0xd]
[task 2022-06-27T18:27:16.833Z] 18:27:16     INFO -       rbx = 0x00007ffc69d8a94c    rbp = 0x00007ffc69d8aa00
[task 2022-06-27T18:27:16.833Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8a830    r12 = 0x00007f2c8cc2f400
[task 2022-06-27T18:27:16.834Z] 18:27:16     INFO -       r13 = 0x00007ffc69d8a938    r14 = 0xaaaaaaaaaaaaaaaa
[task 2022-06-27T18:27:16.834Z] 18:27:16     INFO -       r15 = 0x00007f2c9cc405c8    rip = 0x00007f2c9f390e28
[task 2022-06-27T18:27:16.834Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.835Z] 18:27:16     INFO -   2  libxul.so!js::WasmModuleObject::construct(JSContext*, unsigned int, JS::Value*) [WasmJS.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 1800 + 0x13]
[task 2022-06-27T18:27:16.835Z] 18:27:16     INFO -       rbx = 0xfffa800000000000    rbp = 0x00007ffc69d8aaf0
[task 2022-06-27T18:27:16.835Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8aa10    r12 = 0x00007f2c8c5cc538
[task 2022-06-27T18:27:16.836Z] 18:27:16     INFO -       r13 = 0xfffa800000000000    r14 = 0xaaaa00a900000001
[task 2022-06-27T18:27:16.836Z] 18:27:16     INFO -       r15 = 0x00007f2c8cc2f400    rip = 0x00007f2ca4074896
[task 2022-06-27T18:27:16.836Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.837Z] 18:27:16     INFO -   3  libxul.so!CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 421 + 0x11]
[task 2022-06-27T18:27:16.837Z] 18:27:16     INFO -       rbx = 0x00007f2c8cc0d800    rbp = 0x00007ffc69d8ab70
[task 2022-06-27T18:27:16.837Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8ab00    r12 = 0x00007f2c8cc0d800
[task 2022-06-27T18:27:16.838Z] 18:27:16     INFO -       r13 = 0x00007ffc69d8ad70    r14 = 0x00007f2c8cc2f400
[task 2022-06-27T18:27:16.838Z] 18:27:16     INFO -       r15 = 0x00007f2ca40747c0    rip = 0x00007f2ca3110fe1
[task 2022-06-27T18:27:16.838Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.839Z] 18:27:16     INFO -   4  libxul.so!CallJSNativeConstructor(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), JS::CallArgs const&) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 437 + 0xf]
[task 2022-06-27T18:27:16.839Z] 18:27:16     INFO -       rbx = 0x00007ffc69d8ad70    rbp = 0x00007ffc69d8abd0
[task 2022-06-27T18:27:16.839Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8ab80    r12 = 0x00007ffc69d8ab88
[task 2022-06-27T18:27:16.840Z] 18:27:16     INFO -       r13 = 0x00007f2ca5b46698    r14 = 0x00007f2ca40747c0
[task 2022-06-27T18:27:16.840Z] 18:27:16     INFO -       r15 = 0x00007f2c8cc2f400    rip = 0x00007f2ca311f9ca
[task 2022-06-27T18:27:16.840Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.841Z] 18:27:16     INFO -   5  libxul.so!InternalConstruct(JSContext*, js::AnyConstructArgs const&) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 634 + 0x16]
[task 2022-06-27T18:27:16.841Z] 18:27:16     INFO -       rbx = 0x00002aa2370e8580    rbp = 0x00007ffc69d8ac30
[task 2022-06-27T18:27:16.841Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8abe0    r12 = 0x00007ffc69d8abe8
[task 2022-06-27T18:27:16.842Z] 18:27:16     INFO -       r13 = 0x00007f2ca5b46698    r14 = 0x00007f2c8cc2f400
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00007ffc69d8ad70    rip = 0x00007f2ca31126cb
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -   6  libxul.so!Interpret(JSContext*, js::RunState&) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 3315 + 0x54]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007f2c8cc2f400    rbp = 0x00007ffc69d8b100
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8ac40    r12 = 0x0000000000000000
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007f2ca5b3c1f0    r14 = 0x0000000000000001
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x000000000000007c    rip = 0x00007f2ca3105d8b
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -   7  libxul.so!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 390 + 0xa]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007f2c8f577101    rbp = 0x00007ffc69d8b160
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8b110    r12 = 0x00007f2c8cc2f400
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007f2c8be2a2e1    r14 = 0x00007ffc69d8b1b0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x0000000000000000    rip = 0x00007f2ca30fd68d
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -   8  libxul.so!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 540 + 0x7]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x000013516901d1b8    rbp = 0x00007ffc69d8b210
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8b170    r12 = 0x0000000000000000
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007ffc69d8b2c8    r14 = 0x00007f2c8cc2f400
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0xfff8800000000000    rip = 0x00007f2ca31106d6
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -   9  libxul.so!js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICFallbackStub*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) [BaselineIC.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 1582 + 0x12]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x0000000000000002    rbp = 0x00007ffc69d8b540
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8b220    r12 = 0x00007ffc69d8b5b0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x0000000000000072    r14 = 0x00007f2c8be41370
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x0000000000000000    rip = 0x00007f2ca3a3211d
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  10  0x246456c874c3
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x0000246456cb6ca0    rbp = 0x00007ffc69d8b5c0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8b550    r12 = 0x0000000000000008
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007f2c8c5cc098    r14 = 0x00007f2c8cc29589
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00007f2c8c5cc0b8    rip = 0x0000246456c874c4
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  11  0x246456cb2dc3
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbp = 0x00007ffc69d8b670    rsp = 0x00007ffc69d8b5d0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rip = 0x0000246456cb2dc4
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: previous frame's frame pointer
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  12  0x246456c7cd88
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbp = 0x00007ffc69d8b6d0    rsp = 0x00007ffc69d8b680
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rip = 0x0000246456c7cd89
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: previous frame's frame pointer
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  13  libxul.so!js::jit::EnterBaselineInterpreterAtBranch(JSContext*, js::InterpreterFrame*, unsigned char*) [BaselineJIT.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 203 + 0x290]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbp = 0x00007ffc69d8ba70    rsp = 0x00007ffc69d8b6e0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rip = 0x00007f2ca3a3ac53
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: previous frame's frame pointer
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  14  libxul.so!Interpret(JSContext*, js::RunState&) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 2194 + 0x19]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0xffffffffffffffc0    rbp = 0x00007ffc69d8bf40
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8ba80    r12 = 0x0000000000000001
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007f2ca5b3c1f0    r14 = 0x00007ffc69d8bef0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x0000000000000000    rip = 0x00007f2ca30fe233
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  15  libxul.so!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 390 + 0xa]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007f2c8f577100    rbp = 0x00007ffc69d8bfa0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8bf50    r12 = 0x00007f2c8cc2f400
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007f2c8bffefd1    r14 = 0x00007ffc69d8bfc0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00000a1b314b8df0    rip = 0x00007f2ca30fd68d
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  16  libxul.so!js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, js::AbstractFramePtr, JS::MutableHandle<JS::Value>) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 782 + 0x7]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00002aa237050038    rbp = 0x00007ffc69d8c040
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8bfb0    r12 = 0x00007ffc69d8c0c8
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007ffc69d8bfc8    r14 = 0x00007ffc69d8bff8
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00007f2c8cc2f400    rip = 0x00007f2ca311367b
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  17  libxul.so!js::Execute(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::MutableHandle<JS::Value>) [Interpreter.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 814 + 0x14]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007f2c8cc2f400    rbp = 0x00007ffc69d8c0a0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8c050    r12 = 0x00007ffc69d8c0c8
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007ffc69d8c068    r14 = 0x0000000000000000
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00002aa23704f030    rip = 0x00007f2ca3113b7c
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  18  libxul.so!JS::Evaluate(JSContext*, JS::ReadOnlyCompileOptions const&, JS::SourceText<mozilla::Utf8Unit>&, JS::MutableHandle<JS::Value>) [CompilationAndEvaluation.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 579 + 0x233]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007ffc69d8c0d0    rbp = 0x00007ffc69d8c180
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8c0b0    r12 = 0x00007f2ca5b403e0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007f2c8cc2f400    r14 = 0x00007ffc69d8c1d8
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00007ffc69d8c220    rip = 0x00007f2ca31e4d3b
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  19  libxul.so!ProcessArgs(mozilla::dom::AutoJSAPI&, char**, int, XPCShellDirProvider*) [XPCShellImpl.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 983 + 0x1c]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007ffc69d8d5dc    rbp = 0x00007ffc69d8c2d0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8c190    r12 = 0x00007ffc69d8c440
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x0000000000000000    r14 = 0x00007ffc69d8c230
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x0000000000000016    rip = 0x00007f2c9f278a85
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  20  libxul.so!XRE_XPCShellMain(int, char**, char**, XREShellData const*) [XPCShellImpl.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 1395 + 0x15]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007f2c8c8fd190    rbp = 0x00007ffc69d8c5c0
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8c2e0    r12 = 0x0000000000000001
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007f2c8cc2f400    r14 = 0x0000000000000000
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00007ffc69d8c440    rip = 0x00007f2c9f277527
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  21  xpcshell!main [xpcshell.cpp:6085e9770cdecdf53d9d9c8974b3ba2dc2dce027 : 82 + 0x1e]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x00007f2ca5b364e8    rbp = 0x00007ffc69d8c640
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8c5d0    r12 = 0xaaaaaaaaaaaaaaaa
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x0000000000000000    r14 = 0x00007f2c8f56c100
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x00007ffc69d8c5e8    rip = 0x000056188a1d922e
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  22  libc.so.6!__libc_start_main [libc-start.c : 310 + 0x19]
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x0000000000000000    rbp = 0x000056188a278d70
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8c650    r12 = 0x000056188a1d9040
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007ffc69d8c720    r14 = 0x0000000000000000
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x0000000000000000    rip = 0x00007f2c96ee5b97
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -  23  xpcshell!_start + 0x28
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rbx = 0x0000000000000000    rbp = 0x0000000000000000
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       rsp = 0x00007ffc69d8c710    r12 = 0x000056188a1d9040
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r13 = 0x00007ffc69d8c720    r14 = 0x0000000000000000
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -       r15 = 0x0000000000000000    rip = 0x000056188a1d9069
[task 2022-06-27T18:27:16.855Z] 18:27:16     INFO -      Found by: call frame info

other crashes:

  • application crashed [@ nsContentSecurityUtils::IsEvalAllowed(JSContext*, bool, nsTSubstring<char16_t> const&)]
  • application crashed [@ static nsContentSecurityUtils::IsEvalAllowed(JSContext*, bool, nsTSubstring<char16_t> const&)]
  • application crashed [@ AssignJSString<nsTAutoJSString<char16_t>,nullptr>(JSContext*, nsTAutoJSString<char16_t>&, JSString*)]
Flags: needinfo?(tom)

I believe I fixed this (it was the same solution as the last failure, but I missed a location to apply it.)

Flags: needinfo?(tom)
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b0d5ebbdea5 Move Eval checks higher to encompass JSMs r=bholley

Backed out for causing multiple xpcshell failures.
The xpcshell jobs are crashing mainly but there are also this kind of failures

Push with failures
Push where the xpcshell jobs started to fail

Failure log

Backout link

Flags: needinfo?(tom)
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e686e7acaae3 Move Eval checks higher to encompass JSMs r=bholley https://hg.mozilla.org/integration/autoland/rev/c39b51a0b211 Add test exemptions for expanded eval restrictions r=jdescottes

https://hg.mozilla.org/mozilla-central/rev/e686e7acaae3
https://hg.mozilla.org/mozilla-central/rev/c39b51a0b211

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Regressions: 1777479

I had two needinfo;s didn't know you could do that!

Flags: needinfo?(tom)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: