Closed Bug 1772740 Opened 2 years ago Closed 1 years ago

Dark themes problem with Link Status Redux plugin in Firefox 102 Beta

Categories

(WebExtensions :: General, defect)

Firefox 102
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mr.krzych00, Unassigned)

References

Details

Steps to reproduce:

Opened github repository, microsoft webpage and bugzilla while having Link Status Redux plugin ON and dark theme enabled - tested on fresh profile. [Firefox 102.0b3]

Actual results:

All sites showed their content for a fraction of a second and went completely white until the plugin got disabled or theme changed back to basic.

Expected results:

The site should display normally. Problem doesn't occur on default Firefox theme and did not occur some updates ago.

More information in plugin's issue report and commit description for a workaround applied by the plugin's author to address Firefox dark themes issue: https://github.com/jaatroko/link-status-redux/issues/41 - "[...]The culprit is a (pseudo-)layer
between the overlay iframe and the overlay document that is white with
dark theme but (properly) transparent with light theme.[...]"

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Theme

Hello! I had tried to reproduce the issue with firefox 103.0a1(2022-06-09) and 102.0b5 on Ubuntu 22.04 unfortunately I wasn't able to reproduce the issue.
Could you answer the following questions in order to further investigate this issue.

  1. Does this issue happen with a new profile? Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
  2. Does this issue happen in the latest nightly? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
  3. Do you have any addons installed if so can you list them?
  4. On what OS did you encounter this issue?
Flags: needinfo?(mr.krzych00)
  1. As stated in my first message, tested on a fresh, as in new, profile.
  2. Not using nightly, only beta and the issue still exists on 102.0b5.
  3. Link Status Redux is the addon as stated in the first message. The problem occurs when Link Status Redux is enabled and user uses Dark Theme, some pages turn white like this page here, github repositories or microsoft pages - the comment in author's addon github workaround commit describes a potential issue that dark themes may be having.
  4. Windows 7 and Windows 10. Just now updated 101 to 102.0b5 on Windows 10 and this bug report appeared as completely white page right after the update. On release version this problem does not occur (yet?) and started occurring very recently with beta.

Though as stated... Fresh/New profile + Link Status Redux + Dark Theme Enabled + this bug report URL => white page.
Light Theme ENABLED, Link Status Redux ENABLED => page is displayed correctly
Dark Theme ENABLED, Link Status Redux DISABLED => page is displayed correctly
Dark Theme ENABLED, Link Status Redux ENABLED => page turns white (may require refresh)

Flags: needinfo?(mr.krzych00)

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)

For the record, this regression is also hitting SingleFile when "Link Status Redux" is installed.

The steps to reproduce this regression can be found here: https://github.com/gildas-lormeau/SingleFile/issues/993

Note that you have to enable the Dark mode in Firefox in order to reproduce the issue.

Component: Theme → General
Flags: needinfo?(dao+bmo)
Product: Firefox → WebExtensions

The severity field is not set for this bug.
:robwu, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(rob)

Firefox's behavior is correct, for the reasons explained in https://github.com/jaatroko/link-status-redux/issues/41#issuecomment-1179561845

The extension has since been updated, so marking as WORKSFORME.

Status: UNCONFIRMED → RESOLVED
Closed: 1 years ago
Flags: needinfo?(rob)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.