We want to display contacts' photos or their initial in the Address Book list, like we do in the message header. First we should refactor the code which finds the URL to the photo, so that we can stop copying it around wherever we use it.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/007647012d92
Refactor code for finding a contact's photo. r=aleca

Comment on attachment 9280181 [details]
Bug 1773201 - Refactor code for finding a contact's photo. r=aleca

[Approval Request Comment]
User impact if declined: Unnoticeable for the users, it's needed for development and easier future uplifts.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment on attachment 9280181 [details]
Bug 1773201 - Refactor code for finding a contact's photo. r=aleca

[Triage Comment]
Approved for beta

Thunderbird 102.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/633a3b3a90cd

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/00936977702d
Improve contacts list UI and show profile picture if available. r=darktrojan,Paenglab

Some test failures from this, at least
comm/mailnews/addrbook/test/unit/test_jsaddrbook.js
comm/mailnews/addrbook/test/unit/test_addrBookCard.js

"bundle" is null which used to be a thing: https://hg.mozilla.org/comm-central/diff/00936977702d70732f9aeca7e1e03e8baf78b63b/mailnews/addrbook/modules/AddrBookCard.jsm#l1.25

Oopsie, good catch.
Try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=0f5f9af1afba5821c5a904279c9f50166c86efb4

Reopening due to test failures.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/550af433f8ec
Fix handling of missing bundle in Address Book generateName method. r=freaktechnik

Comment on attachment 9280551 [details]
Bug 1773201 - Improve contacts list UI and show profile picture if available. r=darktrojan,Paenglab

[Approval Request Comment]
User impact if declined: Simple UI improvements for the contacts list
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment on attachment 9281244 [details]
Bug 1773201 - Fix handling of missing bundle in Address Book generateName method. r=freaktechnik

[Approval Request Comment]
User impact if declined: Missing display name and proper first/last name formatting
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment on attachment 9280551 [details]
Bug 1773201 - Improve contacts list UI and show profile picture if available. r=darktrojan,Paenglab

[Triage Comment]
Approved for beta

Comment on attachment 9281244 [details]
Bug 1773201 - Fix handling of missing bundle in Address Book generateName method. r=freaktechnik

[Triage Comment]
Approved for beta

Thunderbird 102.0beta7:
https://hg.mozilla.org/releases/comm-beta/rev/7e3be30bf6c5
https://hg.mozilla.org/releases/comm-beta/rev/0a52289fb8ee