Closed Bug 1773222 Opened 2 years ago Closed 2 years ago

Speed up gn config filtering

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task

Tracking

(firefox-esr102 fixed, firefox102 fixed, firefox103 fixed)

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- fixed
firefox102 --- fixed
firefox103 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1773222 - Speed up gn config filtering.
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-release+
pascalc
: approval-mozilla-esr102+
Details
No description provided.

This brings down the operation from 12s to 8ms on my machine. Yes,
that's seconds versus milliseconds.

Blocks: 1773223
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/bd99aacf19b4 Speed up gn config filtering. r=firefox-build-system-reviewers,andi

https://hg.mozilla.org/mozilla-central/rev/bd99aacf19b4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

Comment on attachment 9280204 [details]
Bug 1773222 - Speed up gn config filtering.

Beta/Release Uplift Approval Request

  • User impact if declined: Eventually, we'll want bug 1773223 and followups on esr102 for downstreams, and this is a pre-requisite.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): NPOTB
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9280204 - Flags: approval-mozilla-beta?

Comment on attachment 9280204 [details]
Bug 1773222 - Speed up gn config filtering.

Last betas were last week and we already built and shipped our release candidate. I am keeping it on my for a dot release or the next ESR

Attachment #9280204 - Flags: approval-mozilla-release?
Attachment #9280204 - Flags: approval-mozilla-esr102?
Attachment #9280204 - Flags: approval-mozilla-beta?

FWIW, I can live with this not being on release. ESR102 is my target.

Comment on attachment 9280204 [details]
Bug 1773222 - Speed up gn config filtering.

We have a driver for a RC2 and ESR, I am taking this patch as a ride-along.

Attachment #9280204 - Flags: approval-mozilla-release?
Attachment #9280204 - Flags: approval-mozilla-release+
Attachment #9280204 - Flags: approval-mozilla-esr102?
Attachment #9280204 - Flags: approval-mozilla-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: