Closed
Bug 177331
Opened 22 years ago
Closed 22 years ago
{inc}multiple left floats containing images have extra space preceding
Categories
(Core :: Layout: Floats, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: elanthis, Assigned: dbaron)
References
()
Details
(Keywords: testcase)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/html
|
Details |
Going to the given URL, on initial page load, sometimes the icons in the page
(all divs with float:left in their styles) are shifted downward. This happens
with Mozilla1.0 all the way up to the latest snapshot. After reloading the
page, and icons are no longer shifted downwards. Leaving the page and
returning, it also works right - only on the first view in the session will it
happen.
In IE6, the icons are never shifted downward at all.
Comment 1•22 years ago
|
||
Confirmed under Linux 2002102804. They are DIVs of class button; the CSS says:
div.button{float: left; text-align: center; padding: 3px; margin: 4px; width:
120px;}
Assignee | ||
Comment 2•22 years ago
|
||
Using a bogus image seems to make things even more reliable due to the
incremental reflow from the image replacement. I think this (for the URL
above) is happening due to the incremental reflows from the image loads, which
is why it's most reliable on shift-reload.
I have a very, very similar problem with this website:
http://ashitaka.home.attbi.com/
Mozilla seems confused as to where the floating div should go, and puts it a few
dozen pixels north of the proper location. When I reload or re-render (pressing
[enter] on the location bar), it shows up properly, as it does in Internet
Explorer 4 and 6.
Assignee | ||
Updated•22 years ago
|
Priority: P4 → P3
Summary: misplaced floats → {inc}misplaced floats
Updated•22 years ago
|
Target Milestone: --- → Future
Assignee | ||
Updated•22 years ago
|
Summary: {inc}misplaced floats → {inc}multiple left floats containing images have extra space preceding
Assignee | ||
Comment 4•22 years ago
|
||
*** Bug 179428 has been marked as a duplicate of this bug. ***
http://ashitaka.home.attbi.com/ testcase is fixed in recent builds. Must have
been a different problem.
Comment 6•22 years ago
|
||
I'm seeing this in some work I'm doing for our online homebase product.
Is there a work around that anyone has found?
It appears as though the height of the elements is being added inside the table.
Is it possible for someone to take a look at this before "Future"?
Keywords: oeone
Assignee | ||
Comment 7•22 years ago
|
||
This is the obvious fix, although the idea of mLastFloaterY is inherently
broken, since it needs to be stored on the space manager so that it applies
across blocks. (I assume we have other bugs on that problem.)
Assignee | ||
Updated•22 years ago
|
Attachment #116871 -
Flags: superreview?(roc+moz)
Attachment #116871 -
Flags: review?(roc+moz)
Assignee | ||
Comment 8•22 years ago
|
||
I filed the mLastFloaterY issue as bug 196919. I may attach a patch there that
supersedes this one, depending on how ambitious I am and how clean my tree is in
the relevant areas...
Comment on attachment 116871 [details] [diff] [review]
simple fix
looks good. But should the space manager PushState/PopState save and restore
mLastFloaterY?
Attachment #116871 -
Flags: superreview?(roc+moz)
Attachment #116871 -
Flags: superreview+
Attachment #116871 -
Flags: review?(roc+moz)
Attachment #116871 -
Flags: review+
Assignee | ||
Comment 10•22 years ago
|
||
They should, once it's in the space manager, which it will be once I attach the
patch.
Assignee | ||
Comment 11•22 years ago
|
||
Taking, although the patch is now elsewhere.
Assignee: float → dbaron
Priority: P3 → P1
Target Milestone: Future → mozilla1.4alpha
Assignee | ||
Updated•22 years ago
|
Attachment #116871 -
Attachment is obsolete: true
Assignee | ||
Comment 12•22 years ago
|
||
Fix checked in to trunk, 2003-03-11 15:56 PST (see bug 196919).
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•22 years ago
|
||
*** Bug 193809 has been marked as a duplicate of this bug. ***
Comment 14•22 years ago
|
||
*** Bug 165699 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 15•22 years ago
|
||
*** Bug 167481 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•