Closed Bug 1773485 Opened 2 years ago Closed 2 years ago

Drop-down menus in dialog "Add a personal OpenPGP Key for ..." does not follow dark theme

Categories

(Thunderbird :: Theme, defect)

Thunderbird 102
defect

Tracking

(thunderbird_esr91 unaffected, thunderbird102 fixed, thunderbird103 affected)

RESOLVED FIXED
103 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird102 --- fixed
thunderbird103 --- affected

People

(Reporter: australstrompetrel, Assigned: Paenglab)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image TB new OpenPGP key.png (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

  1. Open the OpenPGP Key Manager via menu "Tools"
  2. Click on the menu "Generate" and "New Key Pair"
  3. Click on the drop-down menu "Key expires in" or "Key type" or "Key size"

Happened in 102.0b4 (32-bit) under Windows 7.

Actual results:

The drop-down menus does not follow the dark theme.

Expected results:

The drop-down menus should follow the dark theme.

Blocks: tb102found
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → 103 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f2850a9816d0
Add contextMenu.css to more PGP key dialogs. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9280489 [details]
Bug 1773485 - Add contextMenu.css to more PGP key dialogs. r=aleca

[Approval Request Comment]
User impact if declined: on older Windows versions wrong popup colours on some PGP dialogs. Fixes also missed changes from bug 1768505
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9280489 - Flags: approval-comm-beta?

Comment on attachment 9280489 [details]
Bug 1773485 - Add contextMenu.css to more PGP key dialogs. r=aleca

[Triage Comment]
Approved for beta

do you mean bug 1768505 or bug 1773525? for "we'd need to wait until the icon patch will be uplifted until we can uplift this one" ?

Flags: needinfo?(richard.marti)
Attachment #9280489 - Flags: approval-comm-beta? → approval-comm-beta+

I meant bug 1768505 attachment 9279293 [details] (Implement supernova icons in toolbars and main menu). It has approval, so no problem.

Flags: needinfo?(richard.marti)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: