Closed Bug 1773721 Opened 2 years ago Closed 2 years ago

Use JS:: instead of js:: for items in NamespaceImports.h

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED WONTFIX

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

While fixing Bug 1773368, I accidentally introduced some uses of js::Handle in the code instead of the canonical JS::Handle. Since there are a number of pre-existing related issues, I am creating this new bug to tackle them together. The NamespaceImports.h header is used within Spidermonkey internals to avoid JS:: prefixes while working in js:: namespace. When writing signatures for non-namespaced types (like JSFunction), we need to typically qualify common types and we should prefer the canonical version instead of the namespace import.

(This is just minor house-keeping)

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.