Closed Bug 1773752 Opened 2 years ago Closed 2 years ago

Remove workarounds for old SDK versions once macOS 11 SDK is required by configure (bug 1696513)

Categories

(Core :: Widget: Cocoa, task, P2)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- wontfix
firefox104 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(2 files)

Bug 1773752: Remove workarounds for old macOS SDKs and update documentation. r=mstange
(deleted), text/x-phabricator-request
Details
Bug 1773752: Remove more workarounds for old macOS SDKs. r=mstange
(deleted), text/x-phabricator-request
Details

We can remove existing workarounds for old SDKs once bug 1696513 lands, i.e. any code that's only needed for old SDKs..

Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6628f146ad0b Remove workarounds for old macOS SDKs and update documentation. r=mstange

Backed out for causing build bustages. CLOSED TREE

Backout link
Push with failures
Link to failure log
Failure line : /builds/worker/checkouts/gecko/gfx/thebes/gfxMacUtils.cpp:16:14: error: 'kCVImageBufferTransferFunction_sRGB' is only available on macOS 10.13 or newer [-Werror,-Wunguarded-availability-new]

Link to failure log 2
Failure line : python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py::OSXToolchainTest::test_clang TEST-UNEXPECTED-FAIL

Flags: needinfo?(spohl.mozilla.bugs)

Unfortunately, it looks like we can't remove all these workarounds just yet because our deployment target remains 10.12... :-/

Flags: needinfo?(spohl.mozilla.bugs)
Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c7720fa81b26 Remove workarounds for old macOS SDKs and update documentation. r=mstange

https://hg.mozilla.org/mozilla-central/rev/c7720fa81b26

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

We discussed this bug in the macOS Spotlight meeting today and we believe we can remove more code. I'll take a look this week.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
No longer regressions: 1774037
Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76918c8b1adc Remove more workarounds for old macOS SDKs. r=mstange,media-playback-reviewers,padenot

https://hg.mozilla.org/mozilla-central/rev/76918c8b1adc

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: