Thunderbird hangs when trying to add a line at the end of a table in the compose window
Categories
(Core :: DOM: Editor, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | unaffected |
thunderbird_esr102 | --- | fixed |
firefox-esr91 | --- | unaffected |
firefox-esr102 | 104+ | fixed |
firefox102 | --- | wontfix |
firefox103 | --- | wontfix |
firefox104 | --- | fixed |
People
(Reporter: camille.elhage, Assigned: masayuki)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: hang, regression)
Attachments
(2 files)
(deleted),
image/gif
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr102+
|
Details |
Steps to reproduce:
Using TB 102.0b4
1- Open a new compose window
2- Add a table by going to the Insert menu then table - ok
3- On the last line of the table, click on the down arrow to add an additional line below the last line
Actual results:
Thunderbird hangs
Expected results:
An additional line should have been added to the table
Comment 1•2 years ago
|
||
No hang here with 102.0b5 on Mac.
Does it reproduce if you do help > troubleshoot mode?
Updated•2 years ago
|
(In reply to Wayne Mery (:wsmwk) from comment #1)
No hang here with 102.0b5 on Mac.
Does it reproduce if you do help > troubleshoot mode?
Yes TB still hangs when in Troubleshoot mode. I am using TB 102.0b4 under Windows 11.
Comment 3•2 years ago
|
||
(In reply to Camille from comment #2)
(In reply to Wayne Mery (:wsmwk) from comment #1)
No hang here with 102.0b5 on Mac.
Does it reproduce if you do help > troubleshoot mode?Yes TB still hangs when in Troubleshoot mode. I am using TB 102.0b4 under Windows 11.
102.b5 got built yesterday. See if Help > About Thunderbird offers the new beta to you and try again after installing.
Comment 4•2 years ago
|
||
I also cannot reproduce on Windows daily or beta.
(In reply to Arthur K. [He/Him] from comment #3)
..
102.b5 got built yesterday. See if Help > About Thunderbird offers the new beta to you and try again after installing.
Just installed 102.0b5 and I still get the same issue when trying to add a line. I attach a small video.
The issue is still here in 102.0b7 but it has a workaround: insert a line before the last line in the table works. The issue appears only when trying to add a line after the last line in the table.
Comment 9•2 years ago
|
||
I can reproduce that.
Need to first click on the last line to move the add-delete-row widget (mozTableAddRowAfter) showing on the last line. Then click on the arrow-down on it -> hang. Something goes wrong after https://searchfox.org/mozilla-central/rev/3cb31675aeffd10f1f6ae7c40e24b254da7798e5/editor/libeditor/HTMLInlineTableEditor.cpp#304
Assignee | ||
Comment 10•2 years ago
|
||
Could be a regression of bug 1730442.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 11•2 years ago
|
||
It's renamed from CellData
, but cellData
still exists in the wider scope.
https://searchfox.org/mozilla-central/rev/f6a2ef2f028b8f1eb82fa5dc5cb1e39a3baa8feb/editor/libeditor/HTMLTableEditor.cpp#923-924
Therefore, these lines are wrong:
https://searchfox.org/mozilla-central/rev/f6a2ef2f028b8f1eb82fa5dc5cb1e39a3baa8feb/editor/libeditor/HTMLTableEditor.cpp#1049,1053
because cellData
was in the for-loop:
https://searchfox.org/mozilla-central/rev/bc4493c72442ad55aecf6b575edb0df4ed18b113/editor/libeditor/HTMLTableEditor.cpp#1008-1009,1020,1022,1026
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
bugherder |
Assignee | ||
Comment 14•2 years ago
|
||
Comment on attachment 9285985 [details]
Bug 1773848 - Make the for-loop in the lambda in HTMLEditor::InsertTableRowsWithTransaction
refer only cellDataInLastRow
r=m_kato!
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a hung-up bug due to a infinite loop.
- User impact if declined: If web apps enable inline table editor with
Document.execCommand("enableInlineTableEditing")
, user may meet this hung-up. - Fix Landed on Version: 104
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Fixed the mistake at renaming the local variable in a loop. See commit message for the detail.
Comment 15•2 years ago
|
||
Hi Camille, are things working better with TB 104.0b1 now? Would be great if we could get some verification on that before uplifting to ESR.
Reporter | ||
Comment 16•2 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #15)
Hi Camille, are things working better with TB 104.0b1 now? Would be great if we could get some verification on that before uplifting to ESR.
Hello Ryan, yes this problem is solved on my side. The issue is no more here with TB 104.0b1.
Thank you very much for this correction!
Keep it up :)
Comment 17•2 years ago
|
||
Comment on attachment 9285985 [details]
Bug 1773848 - Make the for-loop in the lambda in HTMLEditor::InsertTableRowsWithTransaction
refer only cellDataInLastRow
r=m_kato!
Thanks for the confirmation! Approved for 102.2esr.
Comment 18•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Description
•