Closed
Bug 177400
Opened 22 years ago
Closed 22 years ago
[FIX]ldap array cleanup/leak fixes
Categories
(Directory :: LDAP XPCOM SDK, defect)
Directory
LDAP XPCOM SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dmosedale
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
The usual... some nsCOMArray stuff, some already_AddRefed stuff. THe leak was in
the loop that called PopListener without releasing the pointers....
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #104579 -
Flags: review?(dmose)
|
|
Assignee | |
Updated•22 years ago
|
Summary: ldap array cleanup/leak fixes → [FIX]ldap array cleanup/leak fixes
|
||
Comment 2•22 years ago
|
||
Comment on attachment 104579 [details] [diff] [review]
voila
r=dmose
Attachment #104579 -
Flags: review?(dmose) → review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #104579 -
Flags: superreview?(alecf)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 104579 [details] [diff] [review]
voila
sr=alecf
nice use of already_AddRefed
Attachment #104579 -
Flags: superreview?(alecf) → superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
danke.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•