Closed Bug 1774385 Opened 2 years ago Closed 2 years ago

Replace multiple ChromeUtils.defineModuleGetter call with one XPCOMUtils.defineLazyModuleGetters

Categories

(Toolkit :: Form Autofill, task, P3)

Product:
Toolkit
Component:
Form Autofill
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: dimi, Assigned: anthonyhungck, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1774385 - Replace multiple ChromeUtils.defineModuleGetter call with one XPCOMUtils.defineLazyModuleGetters in Form Autofill. r=dimi
(deleted), text/x-phabricator-request
Details

We use ChromeUtils.defineModuleGetter in a lot of places in the formautofill component (Ex. FormAutofillHeuristics.jsm, FormAutofillChild.jsm, etc)
We can replace this with XPCOMUtils.defineLazyModuleGetters to merge multiple ChromeUtils.defineModuleGetter calls into one XPCOMUtils.defineLazyModuleGetters call.

Can I work on this?

(In reply to Anthony Hung from comment #1)

Can I work on this?

Sure, feel free to take this bug

Assignee: nobody → anthonyhungck
Status: NEW → ASSIGNED
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a33bc3dc504b Replace multiple ChromeUtils.defineModuleGetter call with one XPCOMUtils.defineLazyModuleGetters in Form Autofill. r=dimi
Pushed by imoraru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58b4244e5188 fix lint failures in FormAutofillHandler.jsm. CLOSED TREE r=fix

https://hg.mozilla.org/mozilla-central/rev/a33bc3dc504b
https://hg.mozilla.org/mozilla-central/rev/58b4244e5188

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: