Closed Bug 1774777 Opened 2 years ago Closed 2 years ago

Drag and drop leaves dnd_file(s) behind in /tmp

Categories

(Core :: Widget: Gtk, defect, P3)

Firefox 101
Desktop
Linux
defect

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: lorem.daijoh, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Dragging and dropping an image file will leave a copy of the dragged image behind in /tmp/dnd_file folder.

The copy is deleted after 16.6 minutes, assuming Firefox is still running at that point. If Firefox has been closed before the timeout, the copy is never removed.

Tested on Ubuntu 18.04, where this happens ONLY with Unity Desktop. Gnome and KDE are not affected.

The bug seems to have appeared somewhere between Firefox 91 (not affected) and 100 (affected).

The likely culprit seems to be patch https://hg.mozilla.org/mozilla-central/rev/3b98ceafb59a for Firefox 96.

The oddly long timeout is likely result of using NS_DND_TIMEOUT (which is in microseconds) for g_timeout_add that expects milliseconds.

But why Unity creates the tmp files in the first place, while Gnome and KDE appear not to, is not clear to me.

Assignee: nobody → jhorak
Blocks: linuxdad
Priority: -- → P3

I do see that on Gnome too, it depends on actual D&D target.

Assignee: jhorak → stransky
  • Use 5 min timeout value to mTempFileTimerID so D&D files from /tmp are removed after a longer period.
  • Remove all temporary files from nsDragService destructor.
  • Add more logs.
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/819e171e6595 [Linux] Remove temporary D&D files from /tmp r=emilio
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
QA Whiteboard: [qa-108b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: