Closed Bug 1775150 Opened 2 years ago Closed 2 years ago

Cleanup js/xpconnect includes

Categories

(Core :: XPConnect, enhancement)

Firefox 91
enhancement

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: serge.guelton, Assigned: serge.guelton)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Steps to reproduce:

Run include-what-you use on js/xpconnect directory

Actual results:

Unused headers got reported

Expected results:

Less headers should be reported

Blocks: 1772757
Assignee: nobody → serge.guelton
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

The Bugbug bot thinks this bug should belong to the 'Core::XPConnect' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → XPConnect
Product: Firefox → Core
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/004885c1597c Cleanup js/xpconnect includes r=sylvestre

Backed out for causing bustage on mozJSModuleLoader.h

[task 2022-06-25T13:56:01.246Z] 13:56:01     INFO -  In file included from /builds/worker/checkouts/gecko/dom/base/ChromeUtils.cpp:55:
[task 2022-06-25T13:56:01.246Z] 13:56:01     INFO -  /builds/worker/checkouts/gecko/js/xpconnect/loader/mozJSModuleLoader.h:23:10: fatal error: 'xpcIJSGetFactory.h' file not found
[task 2022-06-25T13:56:01.247Z] 13:56:01     INFO -  #include "xpcIJSGetFactory.h"
[task 2022-06-25T13:56:01.247Z] 13:56:01     INFO -           ^~~~~~~~~~~~~~~~~~~~
[task 2022-06-25T13:56:01.247Z] 13:56:01     INFO -  1 error generated.
[task 2022-06-25T13:56:01.248Z] 13:56:01    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:668: Unified_cpp_dom_base1.o] Error 1
[task 2022-06-25T13:56:01.248Z] 13:56:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/base'
[task 2022-06-25T13:56:01.248Z] 13:56:01     INFO -  gmake[4]: *** Waiting for unfinished jobs....
Flags: needinfo?(serge.guelton)
No longer blocks: 1772757

Sorry for the inconvenience. I'm rebasing the patch and adjust.

Flags: needinfo?(serge.guelton)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: