Closed
Bug 177573
Opened 22 years ago
Closed 22 years ago
chimera.js is interpreted before all.js
Categories
(Camino Graveyard :: Preferences, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ccarlen, Assigned: sfraser_bugs)
Details
I think that a product-specific prefs file like chimera.js should be able to
override prefs in all.js. Currently, because of the way the interpreting of pref
default files is ordered, we get (from some prints inserted):
openPrefFile: opening
/Users/conrad/Development/CHIMERA/mozilla/chimera/build/Navigator.app/Contents/MacOS/defaults/pref/initpref.js
openPrefFile: opening
/Users/conrad/Development/CHIMERA/mozilla/chimera/build/Navigator.app/Contents/MacOS/defaults/pref/security-prefs.js
openPrefFile: opening
/Users/conrad/Development/CHIMERA/mozilla/chimera/build/Navigator.app/Contents/MacOS/defaults/pref/chimera.js
openPrefFile: opening
/Users/conrad/Development/CHIMERA/mozilla/chimera/build/Navigator.app/Contents/MacOS/defaults/pref/all.js
openPrefFile: opening
/Users/conrad/Development/CHIMERA/mozilla/chimera/build/Navigator.app/Contents/MacOS/defaults/pref/debug-developer.js
There is a way around this: See
http://lxr.mozilla.org/seamonkey/source/modules/libpref/src/nsPrefService.cpp#495
I think we should rename chimera.js -> chimera-all.js
Reporter | ||
Comment 1•22 years ago
|
||
Fixing summary.
Summary: chimera.js is interpreted after all.js → chimera.js is interpreted before all.js
Assignee | ||
Comment 2•22 years ago
|
||
I'm trying to understand how "all.js" can sort after "chimera.js"
Reporter | ||
Comment 3•22 years ago
|
||
Look at the code in the lxr link - It's just an inverted sort.
Assignee | ||
Comment 4•22 years ago
|
||
They reverse sort just to fix the '.' vs '-' problem? That's insane.
Reporter | ||
Comment 5•22 years ago
|
||
I thought they meant that "-" meant "modifier" and so foo-bar.js should come
after foo.js. Still, inverting the whole sort to accomplish that is wacky. But,
we need some reasonable way of ordering these so that we can override things in
all.js.
Assignee | ||
Comment 6•22 years ago
|
||
I have to fix this for favicons. I'll rename it to all-chimera.js.
Assignee: ccarlen → sfraser
Assignee | ||
Comment 7•22 years ago
|
||
Done. chimera.js was renamed to all-chimera.js. Stupid prefs code.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•