Closed Bug 1776049 Opened 2 years ago Closed 2 years ago

Intermittent accessible/tests/browser/bounds/browser_zero_area.js | single tracking bug

Categories

(Core :: Disability Access APIs, defect, P3)

Product:
Core
Component:
Disability Access APIs
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: jmaher, Assigned: Jamie)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Bug 1776049: Ignore visibility when checking focusability to determine whether to create an Accessible.
(deleted), text/x-phabricator-request
Details
No description provided.

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1776049

Severity: -- → S4

Update:

There have been 30 failures within the last 7 days:

  • 1 failure on Windows 11 x64 22H2 WebRender opt
  • 29 failures on OS X 11 WebRender Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=409423003&repo=mozilla-central&lineNumber=1855

[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - TEST-PASS | accessible/tests/browser/bounds/browser_zero_area.js | Remote IFRAME is in a different process. - 
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - Buffered messages finished
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/bounds/browser_zero_area.js | Uncaught exception in test bound  - at chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:284 - TypeError: can't access property "getBounds", accessible is null
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - Stack trace:
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - getBounds@chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:284:3
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - @chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:921:5
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - untilCacheCondition/<@chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:837:16
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - untilCacheCondition@chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:836:10
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - testBoundsWithContent@chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:920:27
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - async*@chrome://mochitests/content/browser/accessible/tests/browser/bounds/browser_zero_area.js:114:11
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - accessibleTask/</<@chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:557:15
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.sys.mjs:154:22
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - async*accessibleTask/<@chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:476:28
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - handleTask@chrome://mochikit/content/browser-test.js:1039:26
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1028:14
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13
[task 2023-03-19T23:48:25.542Z] 23:48:25     INFO - Leaving test bound 
[task 2023-03-19T23:48:25.670Z] 23:48:25     INFO - GECKO(2645) | MEMORY STAT | vsize 402328MB | residentFast 364MB | heapAllocated 131MB
[task 2023-03-19T23:48:25.670Z] 23:48:25     INFO - TEST-OK | accessible/tests/browser/bounds/browser_zero_area.js | took 3776ms

James, can you help us assign this to someone?
Thank you.

Flags: needinfo?(jteh)
Whiteboard: [stockwell needswork:owner]

I'm looking into this.

Assignee: nobody → jteh
Flags: needinfo?(jteh)

This is an extension of the fix in bug 1775684.
In that fix, I tweaked NativeInteractiveState to ignore visibility when calling nsIFrame::IsFocusable, since otherwise, an invisible document would report that nothing was focused.
That works well if an Accessible would be created for other reasons; e.g. because it has a meaningful role.
However, if an element has no semantic value except for its focusability (e.g. <span tabindex="-1">), we were failing to create an Accessible for it altogether.
Now, we also ignore visibility when checking focusability in nsAccessibilityService::MustBeAccessible.
This means that we do create an Accessible in this case.
We don't need a caching check here because we should always create an Accessible in this case, even if the document is initially invisible.

Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb4138daaec8 Ignore visibility when checking focusability to determine whether to create an Accessible. r=morgan

https://hg.mozilla.org/mozilla-central/rev/eb4138daaec8

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: