screen-reader-only class in email table disrupting Orca table navigation
Categories
(Thunderbird :: Address Book, defect)
Tracking
(thunderbird_esr102 fixed, thunderbird103 fixed)
People
(Reporter: henry-x, Assigned: henry-x)
References
(Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: [TM:102.0.1optimistic])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
rjl
:
approval-comm-beta+
rjl
:
approval-comm-esr102+
|
Details |
Steps to reproduce with Orca:
- Navigate to the addressbook table and add two rows.
- Focus the second address input.
- Insert+A to switch to browse mode.
- Shift+Alt+ArrowRight. Moves to the checkbox, and announces row and column.
- Shift+Alt+ArrowUp. Moves to the checkbox on the first row, and announces row and column.
- Shift+Alt+ArrowLeft. Moves focus to email address input, and announces row and column.
- Shift+Alt+ArrowLeft. Moves focus to the selector, and announces row and column.
- Shift+Alt+ArrowRight. Does nothing!
Basically, as soon as you get to the first column, you get trapped there. I tracked it down, and, ironically, it is caused by the screen-reader-only rule:
position: absolute;
Removing the line gets it to work. I think it may have to do with the fact that browse mode takes the screen position of elements into account, and the lack of a position may be throwing it off. Not sure if this would be considered a bug with Orca.
Assignee | ||
Comment 1•2 years ago
|
||
We move the screen-reader-only
class to a contained <span>
element instead. Thus the <span> has position: absolute
applied to it instead of the <th>
, but the <th>
still has the required text content.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Pushed by nicolai@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/1c38fde68b4b
Avoid screen-reader-only class on <th> elements in addressbook email table. r=aleca
Assignee | ||
Comment 3•2 years ago
|
||
Comment on attachment 9283015 [details]
Bug 1776644 - Avoid screen-reader-only class on <th> elements in addressbook email table. r=aleca
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Broken table navigation when using Orca
Testing completed (on c-c, etc.): Tested manually with Orca
Risk to taking this patch (and alternatives if risky): Low. Minor change to the markup.
Assignee | ||
Comment 4•2 years ago
|
||
Comment on attachment 9283015 [details]
Bug 1776644 - Avoid screen-reader-only class on <th> elements in addressbook email table. r=aleca
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Broken table navigation when using Orca
Testing completed (on c-c, etc.): Tested manually with Orca
Risk to taking this patch (and alternatives if risky): Low. Minor change to the markup.
Updated•2 years ago
|
Comment 5•2 years ago
|
||
Comment on attachment 9283015 [details]
Bug 1776644 - Avoid screen-reader-only class on <th> elements in addressbook email table. r=aleca
[Triage Comment]
Approved for beta
Comment 6•2 years ago
|
||
bugherder uplift |
Thunderbird 103.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/8d8173580e1b
Comment 7•2 years ago
|
||
optimistically approving for TB102.0.1 - assuming it will pass beta over the next several days
Comment 8•2 years ago
|
||
bugherder uplift |
Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/d9ef0d2336c0
Comment 9•2 years ago
|
||
Comment on attachment 9283015 [details]
Bug 1776644 - Avoid screen-reader-only class on <th> elements in addressbook email table. r=aleca
[Triage Comment]
Included in 102.0.1.
Description
•