Support <all_urls> in MV3 web_accessible_resources[].matches
Categories
(WebExtensions :: General, defect, P2)
Tracking
(firefox104 fixed)
Tracking | Status | |
---|---|---|
firefox104 | --- | fixed |
People
(Reporter: oliver, Assigned: mixedpuppy)
References
Details
(Whiteboard: [addons-jira])
Attachments
(2 files)
Steps to reproduce:
- Unzip Archive.zip
- Enable "extensions.manifestV3.enabled" and "xpinstall.signatures.required" in Firefox Nightly.
- Attempt to load the "all_urls" extension.
Actual results:
The extension fails to load because <all_urls> does not match the expected RegEx.
Expected results:
It would be great for this to be supported.
The functionality would be the same as both https://*/*
and http://*/*
which already work today. I've included a "regex" extension which demonstrates this. Load the extension, make sure to give it permission to alter all webpages, and then go to https://example.com/ to see the content script/CSS injected and a red border shown.
Both of these examples work in Chrome.
Comment 1•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 2•2 years ago
|
||
matches
was introduced in bug 1697334, using the MatchPatternRestricted
type. It should have been using the MatchPattern
type instead (https://searchfox.org/mozilla-central/rev/b7642d0089449244d6361680bc619c94bf11725f/toolkit/components/extensions/schemas/manifest.json#621-649).
For comparison, Chrome does not impose any restrictions on the match pattern format: https://source.chromium.org/chromium/chromium/src/+/main:extensions/common/manifest_handlers/web_accessible_resources_info.cc;l=116-126;drc=5867b3b59ed9c5713477656561a99cc543b9d8c5
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Comment 5•2 years ago
|
||
Backed out for causing xpcshell failures at test_ext_web_accessible_resources_matches.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/3827c37b916dd126c417b0904027307f8f3aa4fe
Failure log: https://treeherder.mozilla.org/logviewer?job_id=383549477&repo=autoland&lineNumber=4115
Comment 7•2 years ago
|
||
bugherder |
Assignee | ||
Updated•2 years ago
|
Description
•