Open Bug 1776906 Opened 2 years ago Updated 1 year ago

[HCM] Resize annotation icon difficult to see

Categories

(Core :: Layout, defect)

defect

Tracking

()

Accessibility Severity s3

People

(Reporter: morgan, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

STR:

  1. Open a PDF w/ pdfjs.annotationEditorEnabled enabled
  2. Using the pencil tool, scribble on the PDF 😀
  3. Select the annotation

Expected:
The resize icon in the lower right of the annotation uses colors from the HCM color palette

Actual:
It stays grey/white regardless of user's chosen colors

We should either use Canvas and CanvasText here or ButtonFace and ButtonText.
This is the default FF resize icon, so filing in general themeing instead of PDF specifically. Maybe this belongs in layout?

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
Component: Theme → PDF Viewer
Flags: needinfo?(dao+bmo)
Severity: -- → S3
Attached image image.png (deleted) —

The pdf editor is using the default resizer so I think this bug isn't specific to the pdf editor.
For example, I screenshoted a textarea on Bugzilla with a visible resizer in HCM (Aquatic theme) on Windows 11 and I don't think that it's really visible for people with visual disabilities.

Dao, should this be in Firefox::Theme or somewhere in Layout?

Flags: needinfo?(dao+bmo)
Accessibility Severity: --- → s3
Whiteboard: [access-s3]

No answer from Dao, I'll move this back to Firefox::Theme for now.

Since https://github.com/mozilla/pdf.js/pull/16732 we are no longer using the resize property in PDF.js, so the STRs are no longer valid, but the bug is reproducible on https://developer.mozilla.org/docs/Web/CSS/resize.

Severity: S3 → --
Component: PDF Viewer → Theme
Flags: needinfo?(dao+bmo)

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(dao+bmo)

Moving this to Core::Layout where the resizer styling lives: https://searchfox.org/mozilla-central/rev/dc8348b3730c0d29dafd01c653d9151eaa9bc30f/layout/style/res/scrollbars.css#86
Not sure if context-fill could be used there, the fill color is currently hardcoded in the image: https://searchfox.org/mozilla-central/source/toolkit/themes/shared/icons/resizer.svg

Component: Theme → Layout
Flags: needinfo?(dao+bmo)
Product: Firefox → Core

The severity field is not set for this bug.
:TYLin, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(aethanyc)
Blocks: hcm
Severity: -- → S3
Flags: needinfo?(aethanyc)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: