Closed Bug 1777351 Opened 2 years ago Closed 2 years ago

Forwarding message with non-ASCII content as attachment leads to mojibake (CJK)

Categories

(Thunderbird :: Message Compose Window, defect)

Thunderbird 102
Unspecified
All
defect

Tracking

(thunderbird_esr91 unaffected, thunderbird_esr102? fixed, thunderbird103 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird_esr102 ? fixed
thunderbird103 --- fixed

People

(Reporter: rachel, Assigned: rnons)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intl, regression, Whiteboard: [regression: TB100])

Attachments

(2 files)

Attached file Test non-ASCII.eml (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Import the attached message (.eml file) into a folder by dragging it.

Display message, right click, forward as attachment. In the compose window that opens, double-click the attachment.

Actual results:

Mojibake.

Expected results:

Should be displayed properly.

Attachment #9283510 - Attachment mime type: message/rfc822 → text/plain

Alice, can you please find the regression, it's very easy to reproduce. This works fine in TB 91.

Blocks: tb102found
Flags: needinfo?(alice0775)
Summary: Forwarding message with non-ASCII content leads to mojibake → Forwarding message with non-ASCII content as attachment leads to mojibake
Status: UNCONFIRMED → NEW
Ever confirmed: true
Regressed by: 1760025
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED
Target Milestone: --- → 104 Branch

Many thanks, Alice, for finding this so quickly, and thanks to Ping for fixing it. It's quite a nasty bug, I assume forwarding messages as attachment in CJK languages is broken completely.

Component: Untriaged → Message Compose Window
Keywords: intl
OS: Unspecified → All
Summary: Forwarding message with non-ASCII content as attachment leads to mojibake → Forwarding message with non-ASCII content as attachment leads to mojibake (CJK)

Pushed by nicolai@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/1247665c67a1
Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): bug 1760025
User impact if declined: Forwarding message with non-ASCII content as attachment leads to mojibake
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9283578 - Flags: approval-comm-beta?

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Triage Comment]
Approved for beta

Attachment #9283578 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): 1760025
User impact if declined: Forwarding non-ascii mails as attachment is fubar'd
Testing completed (on c-c, etc.): on beta
Risk to taking this patch (and alternatives if risky):

Attachment #9283578 - Flags: approval-comm-esr102?
Whiteboard: [regression: TB100]

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Triage Comment]
Approved for esr102

Attachment #9283578 - Flags: approval-comm-esr102? → approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: