Closed Bug 1777438 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34658 - [@container] Change initial value of container-type to 'normal'

Tracking

()

Status:

RESOLVED FIXED

Milestone:

104 Branch

Tracking Flags:

Tracking

Status

firefox104

---

fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 years ago

Sync web-platform-tests PR 34658 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34658
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@container] Change initial value of container-type to 'normal'

Per recent CSSWG resolution [1], the initial value is now 'normal'.

The function StyleBuilderConverter::ConvertFlags had hard-coded
handling of CSSValueID::kNone which interpreted that to mean "flags=0".
Since we now also need kNormal to mean "flags=0", this CL adds a
template parameter to indicate which CSSValueID we should treat as
zero.

This CL also disallows the following values from the \<custom-ident>
of the container-name property:

normal, which was clearly intended from reading the discussion
in [1].

auto, which is not explicitly mentioned in [1] as something to
disallow, but it's aligned with the ambition to disallow
none/normal/auto from \<custom-ident> in general [2].

[1] https://github.com/w3c/csswg-drafts/issues/7402
[2] https://github.com/w3c/csswg-drafts/issues/7431

Fixed: 1340859
Change-Id: I841303e2b5673c65d69d97522a0a3661e5d1ec24
Reviewed-on: https://chromium-review.googlesource.com/3736384
WPT-Export-Revision: b777a72db42fd22b6428c5da83fb63bcf546d98c

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Component: web-platform-tests → Layout

Product: Testing → Core

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaa18c73b972f7f95d6f30cd1bc1156391684ee1

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 years ago

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 5 subtests

Status Summary

Firefox

OK : 8
PASS : 172
FAIL : 76
ERROR: 9

Chrome

OK : 9
PASS : 227
FAIL : 37

Safari

OK : 8
PASS : 201
FAIL : 47
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/the-stylepropertymap/properties/container-type.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)
/css/css-contain/container-queries/at-container-parsing.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- (((width: 40x) and (height: 50px)) or (height: 100px)): FAIL (Chrome: PASS, Safari: PASS)
- foo(width): FAIL (Chrome: PASS, Safari: PASS)
- size(width): FAIL (Chrome: PASS, Safari: PASS)
- (asdf): FAIL (Chrome: PASS, Safari: PASS)
- (resolution > 100dpi): FAIL (Chrome: PASS, Safari: PASS)
- (resolution: 150dpi): FAIL (Chrome: PASS, Safari: PASS)
- (color): FAIL (Chrome: PASS, Safari: PASS)
- (min-color: 1): FAIL (Chrome: PASS, Safari: PASS)
- (color-index >= 1): FAIL (Chrome: PASS, Safari: PASS)
- size(grid): FAIL (Chrome: PASS, Safari: PASS)
- (grid): FAIL (Chrome: PASS, Safari: PASS)
- (width == 100px): FAIL (Chrome: PASS, Safari: PASS)
- (100px == width): FAIL (Chrome: PASS, Safari: PASS)
- (100px = width = 200px): FAIL (Chrome: PASS, Safari: PASS)
- (100px < width > 200px): FAIL (Chrome: PASS, Safari: PASS)
- (100px <= width >= 200px): FAIL (Chrome: PASS, Safari: PASS)
- (100px <= width > 200px): FAIL (Chrome: PASS, Safari: PASS)
- (100px < width >= 200px): FAIL (Chrome: PASS, Safari: PASS)
- (100px : width : 200px): FAIL (Chrome: PASS, Safari: PASS)
- screen and (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
- screen or (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
- not screen and (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
- not screen or (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
- (width: 100px) and (height: 100px): FAIL (Chrome: PASS, Safari: PASS)
- (width: 100px) or (height: 100px): FAIL (Chrome: PASS, Safari: PASS)
- not (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
- foo (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
- Container selector: foo foo: FAIL (Chrome: PASS, Safari: PASS)
- Container selector: none: FAIL (Chrome: PASS, Safari: PASS)
- Container selector: None: FAIL (Chrome: PASS, Safari: PASS)
- Container selector: normal: FAIL (Chrome: FAIL, Safari: FAIL)
- Container selector: Normal: FAIL (Chrome: FAIL, Safari: FAIL)
- Container selector: auto: FAIL (Chrome: FAIL, Safari: FAIL)
- Container selector: Auto: FAIL (Chrome: FAIL, Safari: FAIL)
- Container selector: and: FAIL (Chrome: PASS, Safari: FAIL)
- Container selector: or: FAIL (Chrome: PASS, Safari: FAIL)
- Container selector: not: FAIL (Chrome: PASS, Safari: FAIL)
- Container selector: And: FAIL (Chrome: PASS, Safari: FAIL)
- Container selector: oR: FAIL (Chrome: PASS, Safari: FAIL)
- Container selector: nOt: FAIL (Chrome: PASS, Safari: FAIL)
- style(--my-prop: foo): FAIL (Chrome: FAIL, Safari: FAIL)
- style(--my-prop: foo - bar ()): FAIL (Chrome: FAIL, Safari: FAIL)
- style(not ((--foo: calc(10px + 2em)) and ((--foo: url(x))))): FAIL (Chrome: FAIL, Safari: FAIL)
- style((--foo: bar) or (--bar: 10px)): FAIL (Chrome: FAIL, Safari: FAIL)
- style(--foo: bar !important): FAIL (Chrome: FAIL, Safari: FAIL)
- style(--my-prop:): FAIL (Chrome: FAIL, Safari: FAIL)
- style(--my-prop: ): FAIL (Chrome: FAIL, Safari: FAIL)
- style(--foo: bar;): FAIL (Chrome: PASS, Safari: PASS)
- style(--foo): FAIL (Chrome: PASS, Safari: PASS)
- style(style(--foo: bar)): FAIL (Chrome: PASS, Safari: PASS)
/css/css-contain/container-queries/container-computed.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- Property container value 'foo / normal': FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/container-inheritance.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- Property container-type has initial value normal: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/container-name-parsing.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- e.style['container-name'] = "auto" should not set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container-name'] = "normal" should not set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container-name'] = "not" should not set the property value: FAIL (Chrome: PASS, Safari: FAIL)
- e.style['container-name'] = "and" should not set the property value: FAIL (Chrome: PASS, Safari: FAIL)
- e.style['container-name'] = "or" should not set the property value: FAIL (Chrome: PASS, Safari: FAIL)
- e.style['container-name'] = "Not" should not set the property value: FAIL (Chrome: PASS, Safari: FAIL)
- e.style['container-name'] = "aNd" should not set the property value: FAIL (Chrome: PASS, Safari: FAIL)
- e.style['container-name'] = "oR" should not set the property value: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-contain/container-queries/container-parsing.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- e.style['container'] = "none / normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container'] = "foo / normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container'] = "foo bar / normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container'] = "none / none" should not set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container'] = "normal / size" should not set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container'] = "auto / size" should not set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/container-type-computed.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- Property container-type value 'initial': FAIL (Chrome: FAIL, Safari: FAIL)
- Property container-type value 'unset': FAIL (Chrome: FAIL, Safari: FAIL)
- Property container-type value 'normal': FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/container-type-parsing.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- e.style['container-type'] = "normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
- e.style['container-type'] = "none" should not set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/container-units-invalidation.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
- cqi respond when selected container changes type (inline-size -> normal): FAIL (Chrome: FAIL, Safari: FAIL)
- cqb respond when selected container changes type (size -> normal): FAIL (Chrome: FAIL, Safari: FAIL)
- cqb respond when intermediate container changes type (inline-size -> size): FAIL (Chrome: PASS, Safari: PASS)
- cqi respond when selected container changes inline-size: FAIL (Chrome: PASS, Safari: PASS)
- cqb respond when selected container changes block-size: FAIL (Chrome: PASS, Safari: PASS)

Tests Disabled in Gecko Infrastructure

/css/css-typed-om/the-stylepropertymap/properties/container-type.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1778016

Pulsebot

Comment 3

•

2 years ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d0b60a4c1ca [wpt PR 34658] - [@container] Change initial value of container-type to 'normal', a=testonly https://hg.mozilla.org/integration/autoland/rev/361d6830a4cf [wpt PR 34658] - Update wpt metadata, a=testonly

Iulian Moraru

Comment 4

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/4d0b60a4c1ca
https://hg.mozilla.org/mozilla-central/rev/361d6830a4cf

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox104: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 104 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 34658 - [@container] Change initial value of container-type to 'normal'

Categories

(Core :: Layout, task, P4)

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Comment 3

Comment 4