Enable partially implemented WebDriver BIDi features on Nightly channel only
Categories
(Remote Protocol :: WebDriver BiDi, task, P1)
Tracking
(firefox103 fixed, firefox104 fixed)
People
(Reporter: whimboo, Assigned: Sasha)
References
Details
(Whiteboard: [webdriver:m4])
Attachments
(2 files, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details |
(deleted),
text/plain
|
Details |
As discussed in last week's WebDriver meeting we want to only allow clients to use ready to ship
features of the WebDriver BiDi protocol. As such we will have to disallow their usage in beta and release builds of Firefox.
Therefore a preference like remote.bidi.allow-incomplete-api
could be used which is true
only on the nightly channel and false
for releases. Whereby users are free to also switch the value on release builds as well but on their own risk.
There can be a blacklist of commands and events which would have to be checked against whenever a command needs to be run. If present in this list and the pref not set we should return a unknown command
error. In case of events we most likely have to handle a separate list per module to only return available events that are ready to ship.
We should get this added to M4 and most likely have to uplift to 103 due to the already landed partial implementation for script.evaluate
.
Reporter | ||
Updated•2 years ago
|
Comment 1•2 years ago
|
||
I think we should consider a name that doesn't imply that we never enable "incomplete" APIs (e.g. we don't want to imply that we won't support script evalutation until we support browsing contexts, sandboxes, workers, etc.). So maybe remote.bidi.enable-experimental
or something.
Agreed that the implementation can be based on a blocklist of commands that should not be enabled and events that should not be sent, unless the pref is set.
Comment 2•2 years ago
|
||
(In reply to James Graham [:jgraham] from comment #1)
I think we should consider a name that doesn't imply that we never enable "incomplete" APIs (e.g. we don't want to imply that we won't support script evalutation until we support browsing contexts, sandboxes, workers, etc.). So maybe
remote.bidi.enable-experimental
or something.
"experimental" sounds good and often comes up for similar flags.
Reporter | ||
Comment 3•2 years ago
|
||
Great, so after more thinking about it my proposal would then be a boolean preference with the name: remote.bidi.experimental.enabled
. Later we could add more preferences if needed under the remote.bidi.experimental
branch.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Updated•2 years ago
|
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cab01ee2a9ef Enable partially implemented WebDriver BIDi features on Nightly channel only. r=webdriver-reviewers,whimboo,jdescottes
Comment 6•2 years ago
|
||
bugherder |
Assignee | ||
Comment 7•2 years ago
|
||
Comment on attachment 9284675 [details]
Bug 1777951 - Enable partially implemented WebDriver BIDi features on Nightly channel only.
Beta/Release Uplift Approval Request
- User impact if declined: The clients could start using not fully implemented commands "script.evaluate" and "script.callFunction" and might face unexpected errors.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch in bug 1777951 only puts the existing commands "script.evaluate" and "script.callFunction" behind the
remote.experimental.enabled
preference and enables them only in Nightly. - String changes made/needed:
- Is Android affected?: Yes
Comment 8•2 years ago
|
||
:Sasha there are several conflicts between this patch and beta. Could you attach a patch that will graft cleanly to beta?
Assignee | ||
Comment 9•2 years ago
|
||
Assignee | ||
Comment 10•2 years ago
|
||
Comment on attachment 9285307 [details] Bug 1777951 - Enable partially implemented WebDriver BIDi features on Nightly channel only. >https://hg.mozilla.org/try/rev/9cc807346699d45e35cf80e96c36625714d8e783
Comment 12•2 years ago
|
||
Comment on attachment 9284675 [details]
Bug 1777951 - Enable partially implemented WebDriver BIDi features on Nightly channel only.
Approved for 103.0b9, thanks for attaching a patch that grafts cleanly
Description
•