Closed Bug 1778109 Opened 2 years ago Closed 2 years ago

Move certviewer code to use mjs files, rather than defining sourceType for ESLint

Categories

(Firefox :: Security, task)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

With the transition to using ES modules rather than JSMs getting started, we are now using the .mjs extension for those files.

We'd like to transition our content code that is using modules to use the .mjs extension as well - the primary gains of this are that we a) don't need to manually specify sourceType: module for ESLint, b) this gives a visual distinction to developers that the file is a module rather than a regular JavaScript file.

This bug is for:

  • browser/base/content/certerror/aboutNetError.js
  • Files & tests under toolkit/components/certviewer

Note: this depends on bug 1768816 as I think it'll be easier to do the transition once the system files have been transitioned as well.

Bug 1811633 took care of toolkit/components/certviewer.

Bug 1734217 took care of browser/base/content/certerror/aboutNetError.js

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME

I just realised that areweesmifiedyet is still showing 5 files for toolkit/components/certviewer/.

Looks like bug 1811633 missed removing the old jsm files. There's also a couple of actors to update.

Assignee: nobody → standard8
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87fdef76da4c Remove now unused pkijs bundle files. r=keeler https://hg.mozilla.org/integration/autoland/rev/576a12d4be5b Convert toolkit/components/certviewer/ to ES modules. r=keeler
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: