Closed
Bug 1779733
Opened 2 years ago
Closed 2 years ago
Nursery allocated Map values are tenured in a nursery GC even if the map dies
Categories
(Core :: JavaScript: GC, task, P2)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
104 Branch
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
Jan found a problem with the barriers for JS Map and Set object. Nursery allocated values in a nursery allocated map end up getting tenured even if the map itself dies in a nursery GC. This is undesirable and may be affecting our react performance.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → jcoppeard
Attachment #9285615 -
Attachment description: WIP: Bug 1779733 - WIP: Skip post barriers for the values of nusery allocated Maps → Bug 1779733 - Skip post barriers for the values of nusery allocated Maps r?jandem
Status: NEW → ASSIGNED
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77d275dfb4f3
Skip post barriers for the values of nusery allocated Maps r=jandem
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D152035
|
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9285855 [details]
Bug 1779733 - Part 3: Testcase to trace store buffer entries that point to freed memory r?jandem
Revision D152039 was moved to bug 1779833. Setting attachment 9285855 [details] to obsolete.
Attachment #9285855 -
Attachment is obsolete: true
|
||
Comment 6•2 years ago
|
||
Appears to have improved the following on AWFY https://arewefastyet.com/win10/benchmarks/raptor-desktop-jetstream2?numDays=60
WSL-MainRun
You need to log in
before you can comment on or make changes to this bug.
Description
•