Closed Bug 1780139 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34890 - [ComputePressure] Remove CPU frequency information.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34890 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34890
Details from upstream follow.

Wei4 Wang <wei4.wang@intel.com> wrote:

[ComputePressure] Remove CPU frequency information.

CPU frequency statistics are not a good metric. A CPU can
have multiple boost modes depending on which core is running
and depending on whether on AC or DC power. We cannot deduct
that a CPU is stressed just because it is running at a high
frequency. Also it might be running at a lower frequency due
to power settings or being on DC power and then the system
can easily be under pressure at this lower frequency. (GitHub
issue: https://github.com/WICG/compute-pressure/issues/24,
Spec change: https://github.com/WICG/compute-pressure/commit/e3da844ddb2a9bf5d8c86ab561f62bf666ed6d27).

We remove CPU frequency information from the implementation
in this patch and use only CPU utilization temporarily. We
will switch to PressureState in the future according to the
newest spec (https://wicg.github.io/compute-pressure/#pressure-states)
and we are working on a robust algorithm to calculate
PressureState.

Bug: 1339205
Change-Id: I15a17fd1eefeeefaddc5f3df5e2a98b04cac4368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3725753
Reviewed-by: Matthew Denton \<mpdenton@chromium.org>
Commit-Queue: Wei4 Wang \<wei4.wang@intel.com>
Reviewed-by: Raphael Kubo Da Costa \<raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1025486}

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 14 tests and 1 subtests

Status Summary

Firefox

OK : 14
PASS: 1
FAIL: 28

Chrome

OK : 14
PASS: 27
FAIL: 2

Safari

OK : 14
PASS: 1
FAIL: 28

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d7f87d0b8c5 [wpt PR 34890] - [ComputePressure] Remove CPU frequency information., a=testonly
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.