[wpt-sync] Sync PR 34890 - [ComputePressure] Remove CPU frequency information.
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox104 fixed)
Tracking | Status | |
---|---|---|
firefox104 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 34890 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/34890
Details from upstream follow.
Wei4 Wang <wei4.wang@intel.com> wrote:
[ComputePressure] Remove CPU frequency information.
CPU frequency statistics are not a good metric. A CPU can
have multiple boost modes depending on which core is running
and depending on whether on AC or DC power. We cannot deduct
that a CPU is stressed just because it is running at a high
frequency. Also it might be running at a lower frequency due
to power settings or being on DC power and then the system
can easily be under pressure at this lower frequency. (GitHub
issue: https://github.com/WICG/compute-pressure/issues/24,
Spec change: https://github.com/WICG/compute-pressure/commit/e3da844ddb2a9bf5d8c86ab561f62bf666ed6d27).We remove CPU frequency information from the implementation
in this patch and use only CPU utilization temporarily. We
will switch to PressureState in the future according to the
newest spec (https://wicg.github.io/compute-pressure/#pressure-states)
and we are working on a robust algorithm to calculate
PressureState.Bug: 1339205
Change-Id: I15a17fd1eefeeefaddc5f3df5e2a98b04cac4368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3725753
Reviewed-by: Matthew Denton \<mpdenton@chromium.org>
Commit-Queue: Wei4 Wang \<wei4.wang@intel.com>
Reviewed-by: Raphael Kubo Da Costa \<raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1025486}
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 14 tests and 1 subtests
Status Summary
Firefox
OK
: 14
PASS
: 1
FAIL
: 28
Chrome
OK
: 14
PASS
: 27
FAIL
: 2
Safari
OK
: 14
PASS
: 1
FAIL
: 28
Links
Details
New Tests That Don't Pass
- /compute-pressure/compute_pressure_arguments.tentative.https.window.html [wpt.fyi]
- ComputePressureObserver constructor throws when cpuUtilizationThresholds is [-1]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor throws when cpuUtilizationThresholds is [0]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor throws when cpuUtilizationThresholds is [1]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor throws when cpuUtilizationThresholds is [2]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor accepts cpuUtilizationThresholds value [0.05]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor accepts cpuUtilizationThresholds value [0.1]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor accepts cpuUtilizationThresholds value [0.2]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor accepts cpuUtilizationThresholds value [0.5]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor accepts cpuUtilizationThresholds value [0.9]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor accepts cpuUtilizationThresholds value [0.95]:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver constructor throws when cpuUtilizationThresholds has duplicates:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- ComputePressureObserver constructor throws when cpuUtilizationThresholds is [-1]:
- /compute-pressure/compute_pressure_basic.tentative.https.window.html [wpt.fyi]
- An active ComputePressureObserver calls its callback at least once:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- An active ComputePressureObserver calls its callback at least once:
- /compute-pressure/compute_pressure_detached_iframe.tentative.https.html [wpt.fyi]
- ComputePressureObserver.observe() on detached frame rejects:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - ComputePressureObserver.stop() on detached frame returns:
FAIL
(Chrome:PASS
, Safari:FAIL
) - Detaching frame while ComputePressureObserver.observe() settles:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- ComputePressureObserver.observe() on detached frame rejects:
- /compute-pressure/compute_pressure_different_quantizations.tentative.https.window.html [wpt.fyi]
- ComputePressureObserver with a new quantization schema stops all other active observers in the same frame:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- ComputePressureObserver with a new quantization schema stops all other active observers in the same frame:
- /compute-pressure/compute_pressure_different_quantizations_across_iframes.tentative.https.window.html [wpt.fyi]
- ComputePressureObserver with a new quantization schema stops all other active observers:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- ComputePressureObserver with a new quantization schema stops all other active observers:
- /compute-pressure/compute_pressure_disconnect.tentative.https.window.html [wpt.fyi]
- Stopped ComputePressureObservers do not receive updates:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Stopped ComputePressureObservers do not receive updates:
- /compute-pressure/compute_pressure_disconnect_idempotent.tentative.https.window.html [wpt.fyi]
- Stopped ComputePressureObservers do not receive updates:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Stopped ComputePressureObservers do not receive updates:
- /compute-pressure/compute_pressure_disconnect_immediately.tentative.https.window.html [wpt.fyi]
- Stopped ComputePressureObservers do not receive updates:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Stopped ComputePressureObservers do not receive updates:
- /compute-pressure/compute_pressure_multiple.tentative.https.window.html [wpt.fyi]
- Three ComputePressureObserver instances with the same quantization schema receive updates:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Three ComputePressureObserver instances with the same quantization schema receive updates:
- /compute-pressure/compute_pressure_multiple_across_iframes.tentative.https.window.html [wpt.fyi]
- Three ComputePressureObserver instances in different iframes, but with the same quantization schema, receive updates:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Three ComputePressureObserver instances in different iframes, but with the same quantization schema, receive updates:
- /compute-pressure/compute_pressure_observe_idempotent.tentative.https.window.html [wpt.fyi]
- ComputePressureObserver.observe() is idempotent:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- ComputePressureObserver.observe() is idempotent:
- /compute-pressure/compute_pressure_observe_unobserve_failure.tentative.https.window.html [wpt.fyi]
- ComputePressureObserver.observe() requires a valid source:
FAIL
(Chrome:PASS
, Safari:FAIL
) - ComputePressureObserver.unobserve() requires a valid source:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- ComputePressureObserver.observe() requires a valid source:
- /compute-pressure/compute_pressure_take_records.tentative.https.window.html [wpt.fyi]
- Calling takeRecords() before observe():
FAIL
(Chrome:PASS
, Safari:FAIL
) - takeRecords() returns empty record after callback invoke:
FAIL
(Chrome:FAIL
, Safari:FAIL
)
- Calling takeRecords() before observe():
- /compute-pressure/compute_pressure_values.tentative.https.window.html [wpt.fyi]
- ComputePressureObserver quantizes utilization and speed separately:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- ComputePressureObserver quantizes utilization and speed separately:
Comment 4•2 years ago
|
||
bugherder |
Description
•