Closed Bug 1780151 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34892 - Revert "Reland "Fieldset NG: Fix paint order of OOF objects in a LEGEND and the corresponding anonymous content box.""

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34892 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34892
Details from upstream follow.

Findit <findit-for-me@appspot.gserviceaccount.com> wrote:

Revert "Reland "Fieldset NG: Fix paint order of OOF objects in a LEGEND and the corresponding anonymous content box.""

This reverts commit c65216f57e6cfab266510c77e5472fb126e3d23a.

Reason for revert:
Findit (https://goo.gl/kROfz5) identified this CL at revision c65216f57e6cfab266510c77e5472fb126e3d23a as
the culprit for failures in the continuous build including:

Sample Failed Build: https://ci.chromium.org/b/8808235698216366977
Sample Failed Step: compile

If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2Fc65216f57e6cfab266510c77e5472fb126e3d23a&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+c65216f57e6cfab266510c77e5472fb126e3d23a

Original change's description:

Reland "Fieldset NG: Fix paint order of OOF objects in a LEGEND and the corresponding anonymous content box."

This is a reland of commit 538bf46dd9ac492c74cf720bbde3d7fe2d681fe4

The difference from the original CL:
Because the original CL caused a performance regression, this CL adds
a cache of the state of CanContainAbsolutePositionObjects().
LayoutObjectBitfields already has 96 bits, and this CL adds a bit flag
between full_paint_invalidation_reason_ and the bitfields. The size
of LayoutObject is not changed by this CL.

Original change's description:

Fieldset NG: Fix paint order of OOF objects in a LEGEND and the
corresponding anonymous content box.

If a FIELDSET is an OOF container, we made its anonymous content box
an OOF container by setting position:relative. It's bad because OOF
objects in the LEGEND is painted behind the anonymous content box. So
this CL updates OOF container conditions for anonymous fieldset content
boxes, and avoids setting position:relative.

  • ng_fieldset_algorithm.cc:
    Handle NGBreakStatus::kDisableFragmentation.
    Without this change, floated-multicol-in-multicol-crash.html in WPT has
    a DCHECK failure.

Bug: 1341413
Change-Id: I650b3020df53eba5d05f930bc44675b80ff4e90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3764404
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Commit-Queue: Kent Tamura \<tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1025081}

Bug: 1341413
Change-Id: I63cc9938a1a63f11bb7ea1c418839d3155313166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3771160
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Commit-Queue: Kent Tamura \<tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1025577}

Change-Id: If4937f0ca23707f890161bf1f78422b69bc6290f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1341413

Reviewed-on: https://chromium-review.googlesource.com/3770852
WPT-Export-Revision: e868a1ddb790ce03e41e20f0e0baa646ba89b5ec

PR 34892 applied with additional changes from upstream: eb8c9dd1bd397bd9725a509062896a79d077594b, 4d76409b3c2bb69bff8670a19f36bf1a016a37f9, a3a90eec974a7713b95b780256b29dd2b835ee8a
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ca514275159 [wpt PR 34892] - Revert "Reland "Fieldset NG: Fix paint order of OOF objects in a LEGEND and the corresponding anonymous content box."", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.