Closed
Bug 1780857
Opened 2 years ago
Closed 2 years ago
Embedder build broken in js/public/Debug.h if DEBUG not defined
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
105 Branch
People
(Reporter: ptomato, Assigned: ptomato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr102+
|
Details |
This seems to be a case of #if being used instead of #ifdef. Patch incoming.
|
Assignee | |
Comment 1•2 years ago
|
||
The paradigm for DEBUG is that it is defined or not defined, not 1 or 0,
so we have to use ifdef here. Otherwise we get a build error in embedded
SpiderMonkey when DEBUG is not defined.
|
||
Updated•2 years ago
|
Assignee: nobody → philip.chimento
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•2 years ago
|
Blocks: sm-embedding
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/41ccea366887
Change if to ifdef for DEBUG. (r=jimb) DONTBUILD
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
|
|
Assignee | |
Comment 4•2 years ago
|
||
Comment on attachment 9286706 [details]
Bug 1780857 - Change if to ifdef for DEBUG. (r?jimb)
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Without this patch, a common embedder configuration (-UDEBUG) will not build.
- User impact if declined: In practice, downstream distributors will have to carry this patch anyway.
- Fix Landed on Version: 105
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This may have an effect on Firefox in case it was built with -DDEBUG=0. (Although if that was the case, the result would probably already not be what the builder intended.)
Attachment #9286706 -
Flags: approval-mozilla-esr102?
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9286706 [details]
Bug 1780857 - Change if to ifdef for DEBUG. (r?jimb)
Approved for 102.2esr.
Attachment #9286706 -
Flags: approval-mozilla-esr102? → approval-mozilla-esr102+
|
|
||
Comment 6•2 years ago
|
||
| bugherder uplift | ||
status-firefox-esr102:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•