Closed Bug 1782003 Opened 2 years ago Closed 2 years ago

Code for setting lastProfilingFrame in GeckoProfilerRuntime::enable is wrong

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox-esr102 --- wontfix
firefox103 --- wontfix
firefox104 --- wontfix
firefox105 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The code in GeckoProfilerRuntime::enable is incorrect when the top activation is a C++ interpreter activation: in that case lastProfilingFrame will be set to nullptr, which we then use for the first JitActivation. This doesn't make sense.

I noticed this while looking at this code for bug 1780547, but I'm not sure if this bug is causing that issue.

Regressed by: 1364520

If the top activation is a C++ interpreter activation, the code would incorrectly use
nullptr as lastProfilingFrame for the first JitActivation.

Set release status flags based on info from the regressing bug 1364520

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Type: task → defect
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae3796648dd4 Set lastProfilingFrame correctly in GeckoProfilerRuntime::enable. r=iain
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Flags: in-testsuite+

The patch landed in nightly and beta is affected.
:jandem, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(jdemooij)
Flags: needinfo?(jdemooij)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: