Closed
Bug 1782003
Opened 2 years ago
Closed 2 years ago
Code for setting lastProfilingFrame in GeckoProfilerRuntime::enable is wrong
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
105 Branch
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The code in GeckoProfilerRuntime::enable
is incorrect when the top activation is a C++ interpreter activation: in that case lastProfilingFrame
will be set to nullptr, which we then use for the first JitActivation
. This doesn't make sense.
I noticed this while looking at this code for bug 1780547, but I'm not sure if this bug is causing that issue.
Assignee | ||
Comment 1•2 years ago
|
||
If the top activation is a C++ interpreter activation, the code would incorrectly use
nullptr
as lastProfilingFrame
for the first JitActivation
.
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1364520
status-firefox103:
--- → affected
status-firefox104:
--- → affected
status-firefox105:
--- → affected
status-firefox-esr102:
--- → affected
status-firefox-esr91:
--- → affected
Comment 3•2 years ago
|
||
Type: task → defect
Updated•2 years ago
|
Keywords: regression
Updated•2 years ago
|
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae3796648dd4
Set lastProfilingFrame correctly in GeckoProfilerRuntime::enable. r=iain
Comment 5•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Updated•2 years ago
|
Updated•2 years ago
|
Flags: in-testsuite+
Comment 6•2 years ago
|
||
The patch landed in nightly and beta is affected.
:jandem, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox104
towontfix
.
For more information, please visit auto_nag documentation.
Flags: needinfo?(jdemooij)
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(jdemooij)
You need to log in
before you can comment on or make changes to this bug.
Description
•