Closed Bug 1782295 Opened 2 years ago Closed 2 years ago

convert browser.privacySegmentation.enabled to a Nimbus feature

Categories

(Firefox :: Shell Integration, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

(Whiteboard: [fidedi-pbm])

Attachments

(4 files, 1 obsolete file)

We want to be able to experiment with this alongside other MR features, so it ought to be behind Nimbus rather than just a pref.

Severity: -- → S2
Priority: -- → P1
Depends on: 1783942
Attachment #9287771 - Attachment description: WIP: Bug 1782295: Use Nimbus for Felt Privacy window separation r?gijs! → Bug 1782295: Use Nimbus for Felt Privacy window separation r?dao!
Pushed by bhearsum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56c6e1791c69 Use Nimbus for Felt Privacy window separation r=dao
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Backed out for causing failures on browser_startup_mainthreadio.js

[task 2022-08-24T09:40:34.436Z] 09:40:34     INFO - (PoisonIOInterposer) write - C:\Users\task_166132656680949\AppData\Local\Temp\tmpp8d2sftm.mozrunner\places.sqlite-wal
[task 2022-08-24T09:40:34.437Z] 09:40:34     INFO - Buffered messages finished
[task 2022-08-24T09:40:34.437Z] 09:40:34     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected read on C:\Users\task_166132656680949\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Nightly Private Browsing.lnk before becoming idle - 
[task 2022-08-24T09:40:34.437Z] 09:40:34     INFO - Stack trace:
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO -   0x7ffefb09356d
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO -   nsIWindowsShellService.hasMatchingShortcut
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO -   task (resource:///modules/BrowserGlue.jsm:2550:20)
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO -   _scheduleStartupIdleTasks/< (resource:///modules/BrowserGlue.jsm:2888:8)
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO -   ChromeUtils::IdleDispatch handler
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO -   Task ChromeUtils::IdleDispatch
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO -   XREMain::XRE_main
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO - (PoisonIOInterposer) read - C:\Users\task_166132656680949\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Nightly Private Browsing.lnk
[task 2022-08-24T09:40:34.439Z] 09:40:34     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-08-24T09:40:34.440Z] 09:40:34     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected stat on C:\Windows\SysWOW64\propsys.dll before becoming idle - 
[task 2022-08-24T09:40:34.440Z] 09:40:34     INFO - Stack trace:
[task 2022-08-24T09:40:34.440Z] 09:40:34     INFO -   0x7ffefb09356d
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO -   nsIWindowsShellService.hasMatchingShortcut
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO -   task (resource:///modules/BrowserGlue.jsm:2550:20)
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO -   _scheduleStartupIdleTasks/< (resource:///modules/BrowserGlue.jsm:2888:8)
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO -   ChromeUtils::IdleDispatch handler
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO -   Task ChromeUtils::IdleDispatch
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO -   XREMain::XRE_main
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO - (PoisonIOInterposer) stat - C:\Windows\SysWOW64\propsys.dll
[task 2022-08-24T09:40:34.441Z] 09:40:34     INFO - Not taking screenshot here: see the one that was previously logged
Status: RESOLVED → REOPENED
Flags: needinfo?(bhearsum)
Resolution: FIXED → ---
Target Milestone: 106 Branch → ---

Looks like this main thread I/O caused by the expected (one time) shortcut creation that we added to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1762994. We're either going to need to add an exception for it (tempting, as it's a one time only thing, and should only be happening for zip builds), or move it off main thread.

Flags: needinfo?(bhearsum)
Attachment #9287771 - Attachment description: Bug 1782295: Use Nimbus for Felt Privacy window separation r?dao! → Bug 1782295: Use Nimbus for Felt Privacy window separation r=dao!

This happens during lazy startup, and we try to avoid any main thread I/O there. Even though this will only ever happen once, there's really no reason I know of to keep it on the main thread.

Because we're enabling window separation by default we also need to enable shortcut creation in the installer to minimize the possibility of users hitting https://bugzilla.mozilla.org/show_bug.cgi?id=1762994.

Pushed by bhearsum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8016b1f25509 Use Nimbus for Felt Privacy window separation r=dao https://hg.mozilla.org/integration/autoland/rev/8c36812a12dc move private shortcut check & creation to background thread r=barret https://hg.mozilla.org/integration/autoland/rev/b332385ffca4 Enable Private Browsing shortcut creation by default r=bytesized

Backed out for causing Assertion failures on nsDirectoryService.cpp

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: Assertion failure: NS_IsMainThread() (Do not call dirsvc::get on non-main threads!), at /builds/worker/checkouts/gecko/xpcom/io/nsDirectoryService.cpp:191
Flags: needinfo?(bhearsum)
Attachment #9291612 - Attachment description: Bug 1782295: move private shortcut check & creation to background thread r?barret! → WIP: Bug 1782295: move private shortcut check & creation to background thread r?barret!
Attachment #9291612 - Attachment description: WIP: Bug 1782295: move private shortcut check & creation to background thread r?barret! → Bug 1782295: move private shortcut check & creation to background thread r?barret!

Because we're enabling window separation by default we also need to enable shortcut creation in the installer to minimize the possibility of users hitting https://bugzilla.mozilla.org/show_bug.cgi?id=1762994.

Depends on D155598

I don't see any reason to keep this under the same namespace as the other former privacySegmentation prefs - but perhaps I'm missing something here.

Depends on D156733

Attachment #9293562 - Attachment is obsolete: true
Pushed by bhearsum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7475c0da3352 Use Nimbus for Felt Privacy window separation r=dao https://hg.mozilla.org/integration/autoland/rev/b241dfa9a9c8 move private shortcut check & creation to background thread r=barret https://hg.mozilla.org/integration/autoland/rev/b4f418acd214 Enable Private Browsing shortcut creation by default r=bytesized https://hg.mozilla.org/integration/autoland/rev/b1462bbc7934 Rename private window separation pref. r=pbz
Regressions: 1790242
Flags: needinfo?(bhearsum)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: