Port bug 1772006 - Clean up nsString implementation source files
Categories
(Thunderbird :: Upstream Synchronization, task, P1)
Tracking
(thunderbird_esr102 unaffected, thunderbird104 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | --- | unaffected |
thunderbird104 | --- | unaffected |
People
(Reporter: mkmelin, Assigned: benc)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1772006 +++
comm-central bustage:
https://treeherder.mozilla.org/jobs?repo=comm-central&revision=63b80b2a4306cf6cd8cc1d5efc81185e9c39c066
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Just a first pass to should get it compiling again. Posted here in case anyone needs it urgently.
I still need to:
- run through and double-check I didn't screw up any string compares (doing that now)
- reimplement
nsMsgCompose::ReplaceFileURLs()
(used for signatures I think - I might leave this for now if I run out of time)
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
OK. I think that should do it. I've checked it over, but it covers a lot of ground so I think it could really do with more eyeballs.
I did update nsMsgCompose::ReplaceFileURLs()
in the end.
I had to change it to scan forwards rather than backwards. I don't think there's any test coverage. So it compiles, but no guarantees as to actually working! It does look OK to me, but definitely needs testing (and ideally a unit test or two, but I'm calling it a day for now).
Assignee | ||
Comment 4•2 years ago
|
||
Also, I've only compiled under Linux so far - might be platform-specific code (import code?) which might need tweaking too:
try build here should show up platform-specific breakage:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=461ed30ecc3a08f4dc87dfaedd7273f3e1bcf0e4
Assignee | ||
Comment 5•2 years ago
|
||
Looks like we build on mac now...
Just updated the patch with a little fixup on the windows side. Let's see if that's enough to keep it happy...
Assignee | ||
Comment 6•2 years ago
|
||
Just added another couple of minor windows fixups. Uploaded the new patch to phab. Internet playing up here, but I think I got a new try build going. I'll leave it there for today.
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/609f81cdf457
Fix nsString-related bustage from bug 1772006. r=mkmelin
Reporter | ||
Updated•2 years ago
|
Comment hidden (Intermittent Failures Robot) |
Description
•