Closed Bug 1782527 Opened 2 years ago Closed 2 years ago

Set devtools.browsertoolbox.scope default value to "parent-process"

Tracking

(firefox105 fixed)

Status:

RESOLVED FIXED

Milestone:

105 Branch

Tracking Flags:

Tracking

Status

firefox105

---

fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Bug 1782527 - [devtools] Change devtools.chrome-debug-mode default value to parent-process. r=jdescottes. 2 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details

Nicolas Chevobbe [:nchevobbe]

Assignee

Description

•

2 years ago

This will make the default experience with the MBT fast enough so we can enable it everywhere

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

2 years ago

Blocks: 1625937

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 1

•

2 years ago

Attached file Bug 1782527 - [devtools] Change devtools.chrome-debug-mode default value to parent-process. r=jdescottes. (deleted) — Details

Depends on D153353

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

2 years ago

Blocks: 1782667

Pulsebot

Comment 2

•

2 years ago

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/823d61b8ec47
[devtools] Change devtools.chrome-debug-mode default value to parent-process. r=jdescottes.

Treeherder Bug Filer

Updated

•

2 years ago

Regressions: 1782908

Norisz Fay [:noriszfay]

Comment 3

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/823d61b8ec47

Status: ASSIGNED → RESOLVED

Closed: 2 years ago

status-firefox105: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 105 Branch

Sandor Molnar

Comment 4

•

2 years ago

Backed out changeset 823d61b8ec47 (bug 1782527) for causing dt failures in devtools/shared/commands/target/tests/browser_target_command_frames.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/74e6bdc0f7751545d0915810572bb904c35f3a7e

Failure log

Push with failures

Status: RESOLVED → REOPENED

status-firefox105: fixed → ---

Flags: needinfo?(nchevobbe)

Resolution: FIXED → ---

Target Milestone: 105 Branch → ---

Iulian Moraru

Comment 5

•

2 years ago

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/74e6bdc0f775

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 6

•

2 years ago

(In reply to Sandor Molnar from comment #4)

Backed out changeset 823d61b8ec47 (bug 1782527) for causing dt failures in devtools/shared/commands/target/tests/browser_target_command_frames.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/74e6bdc0f7751545d0915810572bb904c35f3a7e

Failure log

Push with failures

I'm having a look at the failure

Flags: needinfo?(nchevobbe)

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 7

•

2 years ago

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #6)

I'm having a look at the failure

Fix attempt https://treeherder.mozilla.org/jobs?repo=try&revision=49dae001ba9aa4a329d6c17dfd1f50df06af1c00

Pulsebot

Comment 8

•

2 years ago

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2464873eef0b
[devtools] Change devtools.chrome-debug-mode default value to parent-process. r=jdescottes.

Natalia Csoregi [:nataliaCs]

Comment 9

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/2464873eef0b

Status: REOPENED → RESOLVED

Closed: 2 years ago → 2 years ago

status-firefox105: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 105 Branch

Julian Descottes [:jdescottes]

Comment 10

•

2 years ago

Big regression on browser toolbox tests console & debugger tests, slight improvement on connect & inspector

== Change summary for alert #35034 (as of Sat, 06 Aug 2022 19:19:09 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
306%	damp browser-toolbox.webconsole-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	2,407.84 -> 9,771.72
289%	damp browser-toolbox.debugger-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	3,051.16 -> 11,868.51
252%	damp browser-toolbox.webconsole-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	2,823.60 -> 9,930.38
216%	damp browser-toolbox.webconsole-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	943.41 -> 2,980.32
214%	damp browser-toolbox.webconsole-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	953.59 -> 2,989.92
198%	damp browser-toolbox.webconsole-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	1,020.51 -> 3,045.90
198%	damp browser-toolbox.webconsole-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	1,019.82 -> 3,038.73
142%	damp browser-toolbox.debugger-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	1,390.80 -> 3,369.90
142%	damp browser-toolbox.debugger-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1,387.68 -> 3,351.55
139%	damp browser-toolbox.debugger-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	1,398.50 -> 3,345.23
137%	damp browser-toolbox.debugger-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	1,396.65 -> 3,316.90
15%	damp simple.netmonitor.open.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	136.59 -> 156.76
10%	damp simple.netmonitor.open.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	155.30 -> 170.56

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
34%	damp browser-toolbox.connect.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1,390.70 -> 921.77
30%	damp browser-toolbox.connect.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	1,420.94 -> 996.96
21%	damp browser-toolbox.inspector-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	422.74 -> 331.92
21%	damp browser-toolbox.inspector-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	426.11 -> 337.99
16%	damp browser-toolbox.inspector-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	536.36 -> 452.79
...	...	...	...	...
13%	damp browser-toolbox.close-process.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	37.02 -> 32.39

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35034

Julian Descottes [:jdescottes]

Comment 11

•

2 years ago

Given the regression on console and debugger, can we do a quick analysis of the issue?

Flags: needinfo?(nchevobbe)

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 12

•

2 years ago

So, it looks like we are waiting for content sources and messages in the test, but since it's parent process only, we don't get them.
You can see error message when running the test:

08:17:45     INFO -  PID 8087 | 8095> Wait for debugger to initializeWait for tab source in the content processException while running code in the browser toolbox:Error: timeout on () => findSource(dbg, testUrl)
[…]
08:17:46     INFO -  PID 8087 | 8095> Wait for test page console message to appear
08:17:49     INFO -  PID 8087 | 8095> JavaScript error: debugger eval code, line 17: Error: timeout on () =>
08:17:49     INFO -  PID 8087 | 8095>       Array.from(
08:17:49     INFO -  PID 8087 | 8095>         hud.ui.window.document.querySelectorAll(".message-body")
08:17:49     INFO -  PID 8087 | 8095>       ).some(el => el.innerText.includes("test page message"))

The test is using evaluateJSAsync for those, so even if we do throw in the evaluation we send, the console actor will return a response, once we hit the timeout. Which is why the test doesn't fail and we only see a regression because we're waiting for the waitFor to timeout basically.

I'll try to make the test properly fail, and then fix it by setting the browser toolbox to the "everything" mode

Flags: needinfo?(nchevobbe)

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

2 years ago

Regressions: 1783610

Henrik Skupin [:whimboo][⌚️UTC+2]

Updated

•

2 years ago

Regressions: 1784355

You need to log in before you can comment on or make changes to this bug.