Per bug 1690561, we want to add an ellipsis to the end of some context menu item labels that are currently missing them. Most of the items are related to bookmarks, but one of them says Print Selection. I'll post Meridel's recommendations below.

Meridel's complete list of recommended string changes

Meridel, I realized we might want to do something different with the Bookmark This Page item. It doesn't actually open a dialog like the other ones, but instead opens the Edit Bookmark Panel. So as with the other "bookmark current page"/"edit bookmark" items, I think it shouldn't have an ellipsis after all.

But Bookmark This Page still seems awkward to me. It doesn't match most of the other items it shares its immediate context with. Most of them lack an article or adjective (like Bookmark Page). But the item right next to it, the reload item, says Reload Current Page. So instead of This it says Current. I suppose we might want to make these consistent with each other.

Since there's a Bookmark Current Tab in the app menu and menubar, and since Reload Current Page is right next to this item, I think it might be reasonable to change it to say Bookmark Current Page (no ellipsis). What do you think? Oh, and that's the item that toggles to Edit This Bookmark btw. I assume that would stay the same, since that's what the equivalent says in the app menu and menubar.

Edit: I suppose an alternative option would be to change Reload Current Page to Reload This Page, but that doesn't fit so well for the toolbar reload button's tooltip. I think "Current" makes sense in both contexts, but "This" makes less sense outside of the content context menu. And I guess the same goes with changing both to Reload Page and Bookmark Page. In the context menu that makes sense, but in the toolbar button I might be wondering "which page?"

Also, just a note to self: some relevant links so we can find these again quickly.

Bookmark This Page
Bookmark Link
Bookmark This Frame
Bookmark Tab
Print Selection

Hi Shane! "Bookmark Page..." is correct. We made a decision to remove the article with the 2020 redesign, and based on our latest copy guidance, it should have an ellipse because "An additional step is required to complete that specific action." (it doesn't matter if that next step is a dialogue or a panel). Like "Save page as..." you need to take an additional action to complete bookmarking or saving in that case.

At this time, I'm not able to revisit use of articles across other context menu items. Re-opening this work will need prioritization from PM.

Hey Meridel, that makes perfect sense. I just miscommunicated. Basically there are two other menuitems/toolbarbuttons that also open the Edit Bookmark Panel, like the Bookmark Page item does. Those ones do not have ellipses, so they would appear inconsistent if we added an ellipsis to the Bookmark Page item. But I think my vote would be for them to all get ellipses. If that sounds right, then I can add ellipses to the other equivalent items too.

I think the confusion is just that one of them said no change in your recommendations, the Bookmark Current Tab item in the OS Menu bar. (There's also a toolbarbutton version of it in the Bookmarks subview of the app menu panel) When the current tab is bookmarked, they both change to Edit this bookmark (in either title case or sentence case), also without an ellipsis, but they continue to open the Edit Bookmark Panel. So I figure we'd wanna change Edit this bookmark to Edit this bookmark... as well?

(Here's the one I'm thinking of)

Apologies, I understand what you mean now. See attached recommendations. Have I captured it all?

Yeah I think that's all of them. Looks great! I have one last question — these are the Edit Bookmark and Bookmark Page strings for the context menu, so I will be changing them to remove "This" and add an ellipsis. But they also have tooltips that reflect the same language, only in sentence case. Should I also remove "this" and add an ellipsis for the tooltips?

Having an ellipsis before a shortcut hint seems a little weird but I found another example where the label just says Print and the tooltip says Print this page… ({ $shortcut }). That one also gives the impression that maybe I should keep "this" in the tooltips, even as I remove it from the labels. So maybe this would look right:

main-context-menu-bookmark-add-with-shortcut =
    .aria-label = Bookmark Page…
    .accesskey = m
    .tooltiptext = Bookmark this page… ({ $shortcut })

main-context-menu-bookmark-change =
    .aria-label = Edit Bookmark…
    .accesskey = m
    .tooltiptext = Edit this bookmark…

main-context-menu-bookmark-change-with-shortcut =
    .aria-label = Edit Bookmark…
    .accesskey = m
    .tooltiptext = Edit this bookmark… ({ $shortcut })

Hi Asa, we are updating some menu labels (see Shane's comment above). We could also update the tooltips that accompany them to mirror the new labels.

Is there an accessibility consideration when deciding whether or not to include articles? For example, would one of these options be more helpful than the other for someone using a screen reader?: "Edit bookmark" vs. "Edit this bookmark."

If applicable, I can capture any guidance you provide here in our Inclusive Writing guidelines (there isn't anything specific to including articles right now).

(In reply to Meridel [:meridel] from comment #8)

Hi Asa, we are updating some menu labels (see Shane's comment above). We could also update the tooltips that accompany them to mirror the new labels.

Is there an accessibility consideration when deciding whether or not to include articles? For example, would one of these options be more helpful than the other for someone using a screen reader?: "Edit bookmark" vs. "Edit this bookmark."

If applicable, I can capture any guidance you provide here in our Inclusive Writing guidelines (there isn't anything specific to including articles right now).

Thanks for asking, Meridel.

The shorter label is definitely more efficient for screen reader users, but if it's determined that the longer label is better for everyone, consistency tops brevity.

Thank you, Asa! I will update our guidelines.

Hi Shane, we can update the tooltip copy here to mirror what we've done in the labels. Based on Asa's comment, making these changes shouldn't cause accessibility issues.

The copy guidance recommends adding an ellipsis to the end of labels for
controls that require an additional step to complete the action
specified by the label. We have some menuitems and panel buttons that
open a bookmark dialog or the edit bookmark panel that don't have an
ellipsis, so add that. Also, the form "Bookmark this x" has been changed
to "Bookmark x" in menuitems. Also, there's a "Print Selection" menuitem
that needed an ellipsis. Thanks for the review!

Hi Meridel, thanks for the update. I set the tooltips to the form Bookmark page (Ctrl+D)

https://hg.mozilla.org/mozilla-central/rev/b9e0299c8460

Verified this issue on Firefox 105.0b6 (20220901185735) on macOS 10.15, Windows 10 and Ubuntu 21.04. Ellipsis were added to all context menu item labels mentioned in Comment 6.