Closed Bug 1783463 Opened 2 years ago Closed 2 years ago

[Quickactions] Too much padding between two QuickActions Rows

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox105 --- disabled
firefox106 --- disabled
firefox107 --- verified

People

(Reporter: mehmet.sahin, Assigned: daisuke)

References

Details

Attachments

(4 files)

actual.png
(deleted), image/png
Details
Bug 1783463: Adjust gap between action buttons.
(deleted), text/x-phabricator-request
Details
Padding still too large with one line.png
(deleted), image/png
Details
Bug 1783463: Remove margin-block-end from help button for quick actions.
(deleted), text/x-phabricator-request
Details
Attached image actual.png (deleted) —

Nightky 105.0a1 (2022-08-05) (64-Bit)
macOS 12.5

1.) Narrow the Window
2.) Focus Address Bar
3.) Notice that you have 2 or more rows with Quickactions

Actual: There is too much padding between two rows (approx. 57px)

Expected: The padding should be the same like two normal suggestions (approx 40px)

Thanks.

Blocks: 1782974
Summary: [Quickactions] Too much padding between two QucikActions Rows → [Quickactions] Too much padding between two QuickActions Rows

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(adw)
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c3d5d2cfbaf Adjust gap between action buttons. r=daleharvey
Severity: -- → S4
Flags: needinfo?(adw)
Priority: -- → P2
Blocks: 1783762

https://hg.mozilla.org/mozilla-central/rev/6c3d5d2cfbaf

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)
status-firefox105: affected → disabled
Flags: needinfo?(daisuke)

Hello daisuke@,

thanks for fixing this. Padding is okay when there is line wrap with 2+ button rows. But with a single row, the padding is still too large.

Can you please take a look again?

A screenshot is attached.

Thanks :)

Flags: needinfo?(daisuke)

Hello Mehmet, I'm sorry for my delay.
Yes, I will fix it.

Flags: needinfo?(daisuke)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af609b2db2db Remove margin-block-end from help button for quick actions. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/af609b2db2db

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
Resolution: --- → FIXED

(In reply to Daisuke Akatsuka (:daisuke) from comment #7)

Yes, I will fix it.

Thanks, looks perfect now in Nightly 106.0a1 (2022-09-07) (64-Bit) :)

Verified as fixed across platforms in latest Nightly 107.0a1 with Quick Actions in Search Mode.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → disabled
status-firefox107: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: