Closed Bug 1783569 Opened 2 years ago Closed 2 years ago

New news JS implementation: Can't drag news message to desktop if newsgroup is downloaded for offline use

Categories

(MailNews Core :: Networking: NNTP, defect)

Product:
MailNews Core
Component:
Networking: NNTP
Version:
Thunderbird 102
Type:
defect

Tracking

(thunderbird_esr102+ fixed, thunderbird104 affected)

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 + fixed
thunderbird104 --- affected

People

(Reporter: b1, Assigned: rnons)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

Bug 1783569 - Prevent malformed url to fix dragging nntp message to desktop. r=mkmelin
(deleted), text/x-phabricator-request
wsmwk
: approval-comm-esr102+
Details

+++ This bug was initially created as a clone of Bug #1780450 +++

On Windows seems to make Windows unresponsive, nothing on the desktop reacts to double-click any more. It eventually crashes after shutting down TB, for example:

https://crash-stats.mozilla.org/report/index/9d68bba0-9214-4229-bf37-b1b360220807
https://crash-stats.mozilla.org/report/index/8d613f76-89ef-458b-be99-23aff0220807

After the crash, the desktop becomes responsive again. That's in TB 101.1.1 with bug 1780450 and bug 1745033 included.

Sorry, TB 102.1.1.

Blocks: tb102found
Keywords: crash, regression

It only hangs if the newsgroup is downloaded for offline use. Maybe this console error is relevant:
NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgFolder.shouldStoreMsgOffline] NntpChannel.jsm:272

We got confused in bug 1780450 where we confirmed that it's working, but it's not working when synchronised for offline use.

Summary: New news JS implementation: Can't drag news message to desktop → New news JS implementation: Can't drag news message to desktop if newsgroup is downloaded for offline use

https://github.com/Betterbird/thunderbird-patches/blob/main/102/bugs/1783569-fix-drag-hang.patch
There may be a better fix since if the article is stored locally, fetching it from the server via _readFromServer() seems unnecessary.
This is a nasty bug since it blocks both the TB UI and also Windows until the situation is "resolved" via the shutdown hang crash.

Crash Signature: shutdownhang | mozilla::TaskController::GetRunnableForMTTask | nsDataObj::CStream::WaitForCompletion | nsDataObj::CStream::Read

NntpChannel failed to parse article number from ?group=name&key=123?fileName=news.eml

Assignee: nobody → remotenonsense
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
status-thunderbird_esr102: --- → affected
Target Milestone: --- → 105 Branch
Keywords: checkin-needed-tb

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/ccf22d87727c
Prevent malformed url to fix dragging nntp message to desktop. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9289223 [details]
Bug 1783569 - Prevent malformed url to fix dragging nntp message to desktop. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1707550
User impact if declined: Can't drag an offline nntp message to desktop on Windows
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Attachment #9289223 - Flags: approval-comm-esr102?

Comment on attachment 9289223 [details]
Bug 1783569 - Prevent malformed url to fix dragging nntp message to desktop. r=mkmelin

[Triage Comment]
Approved for esr102

Attachment #9289223 - Flags: approval-comm-esr102? → approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: