Have UrlbarInterventions trigger appropriate action
Categories
(Firefox :: Address Bar, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox-esr102 | --- | unaffected |
firefox103 | --- | unaffected |
firefox104 | --- | unaffected |
firefox105 | --- | disabled |
firefox106 | --- | verified |
People
(Reporter: aflorinescu, Assigned: daisuke)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Note
- IMO, it comes as a surprise as under the guise of "quick actions", I'm opening sumo pages. It is unexpected that instead of performing an action, as an user I'm redirected towards a sumo page.
Found in
- 105.0a1 (2022-08-09)
Affected versions
- 105.0a1 (2022-08-09)
Affected platforms
- Windows10
Steps to reproduce
- Open Nightly (quick actions enabled - default on Nightly 105)
- In a new tab type in address bar "clear", select and click on Clear History quick action.
- In a new tab type in address bar "refresh", select and click on Refresh Nightly quick action.
Expected result
- Clear History modal is opened.
- Refresh Nightly modal is opened.
Actual result
- Sumo is opened: https://support.mozilla.org/1/firefox/105.0a1/WINNT/en-US/delete-browsing-search-download-history-firefox
- Sumo is opened: https://support.mozilla.org/1/firefox/105.0a1/WINNT/en-US/refresh-firefox-reset-add-ons-and-settings
Regression range
- N/A
Additional notes
- In the same category also enters the Update quick action which has a SUMO as an action and where to my knowledge AFAIK most beef is with ophaned versions and annoyance for updates too often, so maybe that makes sense to be a SUMO.
Comment 1•2 years ago
|
||
I hadn't actually tried these quick actions, but after trying out the two use cases detailed here, this does feel pretty unexpected (and quick and dirty). I could have sworn that the older version of quick actions actually began a Firefox Refresh if users selected from the refresh Firefox prompt, which felt a lot more integrated.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 2•2 years ago
|
||
I was unaware the urlbar interventions triggered the actions as I glanced through the code and on a brief test I only seen the url open which looks like a fallback, refresh, update and clear all have actions that they may be able to trigger so we should do the same
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D155542
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D155543
Updated•2 years ago
|
Comment 7•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b560e670ff0
https://hg.mozilla.org/mozilla-central/rev/a442c08ab22b
https://hg.mozilla.org/mozilla-central/rev/467b4cdb0608
Comment 8•2 years ago
|
||
The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox105
towontfix
.
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 9•2 years ago
|
||
The issue is verified fixed using the latest Fx106.0a1 on Windows 10, macOS and Ubuntu 22. The buttons now correctly point to the intended actions.
Please note that the problem with the update button is addressed in bug 1788666. Clear history and Refresh work correctly.
Description
•