Closed Bug 1784019 Opened 2 years ago Closed 2 years ago

Firefox closes unexpectedly when accessing Restore previous session with Firefox view active

Categories

(Firefox :: Firefox View, defect, P1)

Product:
Firefox
Component:
Firefox View
Version:
Firefox 105
Platform:
Desktop
All
Type:
defect
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox105 --- disabled
firefox106 + verified

People

(Reporter: csasca, Assigned: niklas)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(2 files)

fx view session restore.webm
(deleted), video/webm
Details
Bug 1784019 - Keep window open when restoring if Firefox View is selected. r=gijs,sclements,sfoster
(deleted), text/x-phabricator-request
Details
Attached video fx view session restore.webm (deleted) —

Found in

  • Firefox 105.0a1

Affected versions

  • Firefox 105.0a1

Affected platforms

  • Ubuntu 22.04
  • macOS 11
  • Windows 10

Steps to reproduce

  1. Launch Firefox with browser.tabs.firefox-view=true
  2. Access some random tabs to have them on background and focus Firefox view page
  3. Close Firefox from the menu and restart it with the same profile
  4. Have the focus over Firefox view and select Menu -> History -> Restore previous session

Expected result

  • The previous session is restored without issues

Actual result

  • Firefox closes unexpectedly without any warnings

Regression range

  • New feature.

Additional notes

  • The issue can be seen in the attachment.
Has STR: --- → yes
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Points: --- → 3
Priority: -- → P2
Priority: P2 → P1
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1957e2d8b8b Keep window open when restoring if Firefox View is selected. r=dao

https://hg.mozilla.org/mozilla-central/rev/d1957e2d8b8b
https://hg.mozilla.org/mozilla-central/rev/bca1b3b9bc52

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nbaumgardner)
status-firefox105: affected → disabled
Flags: needinfo?(nbaumgardner)

Verified as fixed with Nightly 106.oa1(2022-09-14) on Windows 10x64, Ubuntu 18.4 and macOS 10.12.6.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: