Closed Bug 1784443 Opened 2 years ago Closed 2 years ago

The FF View Separator is no longer displayed if a "Customize Toolbar" element is placed before it

Categories

(Firefox :: Firefox View, defect, P3)

Firefox 105
Desktop
All
defect
Points:
2

Tracking

()

VERIFIED FIXED
108 Branch
Tracking Status
firefox105 --- wontfix
firefox108 --- verified

People

(Reporter: vlucaci, Assigned: kcochrane)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] )

Attachments

(2 files)

Attached image Separator.gif (deleted) —

Affected versions

  • 105.0a1(2022-08-11)

Affected platforms

  • macOS 11
  • Win 11
  • Win 10
  • Ubuntu 22

Steps to reproduce

  1. Launch FF.
  2. Go to about:config and activate browser.tabs.firefox-view pref.
  3. Restart FF.
  4. Go to More Tools-> Customize toolbar in the burger menu.
  5. Drag any element after the FF View button and before its separator in the Tab bar.

Expected result

  • The FF View separator remains visible.

Actual result

  • The FF view separator is no longer displayed.

Regression range

  • Not a regression

Additional notes

  • The FF View separator remains visible if element is placed before the FF View button.
Priority: -- → P3

This is by design - the separator is supposed to be there to separate the tab from the "real" pinned tabs, which isn't necessary if there are other buttons before it.

We could have the separator appear in front of the tabstrip whenever there are any buttons next to it, but that seems unrelated to FxView.

Adding Josh for feedback here as well.

Flags: needinfo?(jberman)

I'd recommend maintaining the separator between toolbar buttons and pinned tabs. Not critical, but I think visual separation between these different elements is a helpful communication tool

Flags: needinfo?(jberman)
Blocks: 1797520
No longer blocks: firefox-view
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32125b47aa43 Show vertical separator between toolbar buttons section and tabs section in tabstrip r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Points: --- → 2
Flags: qe-verify+

Reproduced the initial issue reported using an old Nightly from 2022-08-12, verified that using Firefox 108.0b2 this is no longer an issue across platforms (Windows 10, macOS 11.6 and Ubuntu 22.04).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1801560
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: