Closed Bug 1784969 Opened 2 years ago Closed 2 years ago

Ensure "Try again" button in fx-view's error state actually refreshes the shared module state

Categories

(Firefox :: General, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: sfoster, Assigned: niklas)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(1 file)

We currently reload the page when the user clicks "Try again" from either the sync-failure or network-offline error state:

        case "view0-sync-error-action":
        case "view0-network-offline-action": {
          this.getWindow().gBrowser.reload();
          break;
        }

However, as the page is essentially just a view onto the state managed by the TabsSetupFlowManager this is likely to change nothing. In the sync-error case we should ensure we are actually refreshing the (tab) sync state - and using SyncedTabs.syncTabs(true) might be a good way to accomplish that.

Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40e01a26be95 Force sync on Firefox View sync error or network offline action. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: