Closed Bug 1784979 Opened 2 years ago Closed 2 years ago

Make Firefox View test helpers available somewhere central

Categories

(Firefox :: Firefox View, task, P3)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: dmosedale, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] )

Attachments

(1 file)

In https://phabricator.services.mozilla.com/D154478, I've created a "Special Messaging Action" called OPEN_FIREFOX_VIEW. To test it, after discussion in #Firefox View, I've temporarily copy-pasted some of the helpers from head.js into the messaging-system code.

It would be wonderful if (some of?) those helpers could be put somewhere more central (eg BrowserUtils) so that they could be used by other modules.

Summary: Make firefox View test helpers available somewhere central → Make Firefox View test helpers available somewhere central
Priority: -- → P3
Whiteboard: [fidefe-2022-mr1-firefox-view]
Blocks: 1797520
No longer blocks: firefox-view

Sarah - Can you help me to understand how useful this revision will be for us? What problem are we trying to solve for?

Flags: needinfo?(sclements)

(In reply to Ray Fambro from comment #1)

Sarah - Can you help me to understand how useful this revision will be for us? What problem are we trying to solve for?

Ray, this is just about making some of the code we use for firefox view tests more easily available and removing duplication (so it doesn't affect users in any way).

Flags: needinfo?(sclements)
Assignee: nobody → sfoster
  • Create a sharable module for the core Firefox-View test helpers
  • Adjust firefoxview's tests (head.js) to use the helper module
  • Adjust messaging-system tests to use the helper module where these helpers were temporarily duplicated
Status: NEW → ASSIGNED
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59d5acb72336 Move some firefoxview test helpers to a shareable module. r=sclements,aminomancer
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: