Closed Bug 1785239 Opened 2 years ago Closed 2 years ago

High frequency TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_h2proxy_connection_limit.js | Test timed out

Categories

(Core :: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox103 --- unaffected
firefox104 --- unaffected
firefox105 --- wontfix
firefox106 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: valentin)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [necko-triaged][stockwell disable-recommended])

Attachments

(1 file)

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=387600398&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YwqomqdyTyuEDw3KesVJEw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YwqomqdyTyuEDw3KesVJEw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2022-08-17T11:04:38.246Z] 11:04:38     INFO -  TEST-START | netwerk/test/unit/test_h2proxy_connection_limit.js
[task 2022-08-17T11:09:38.254Z] 11:09:38  WARNING -  TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_h2proxy_connection_limit.js | Test timed out
[task 2022-08-17T11:09:38.255Z] 11:09:38     INFO -  TEST-INFO took 300008ms
[task 2022-08-17T11:09:38.256Z] 11:09:38     INFO -  >>>>>>>
[task 2022-08-17T11:09:38.256Z] 11:09:38     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-08-17T11:09:38.256Z] 11:09:38     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-08-17T11:09:38.256Z] 11:09:38     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-08-17T11:09:38.256Z] 11:09:38     INFO -  running event loop
[task 2022-08-17T11:09:38.257Z] 11:09:38     INFO -  netwerk/test/unit/test_h2proxy_connection_limit.js | Starting test_connection_limit
[task 2022-08-17T11:09:38.257Z] 11:09:38     INFO -  (xpcshell/head.js) | test test_connection_limit pending (2)
[task 2022-08-17T11:09:38.257Z] 11:09:38     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-08-17T11:09:38.258Z] 11:09:38     INFO -  "socket count is 6
[task 2022-08-17T11:09:38.258Z] 11:09:38     INFO -  "
[task 2022-08-17T11:09:38.258Z] 11:09:38     INFO -  TEST-PASS | netwerk/test/unit/test_h2proxy_connection_limit.js | test_connection_limit - [test_connection_limit : 78] socket count should be less than maxConnections - true == true
[task 2022-08-17T11:09:38.258Z] 11:09:38     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-08-17T11:09:38.259Z] 11:09:38     INFO -  (xpcshell/head.js) | test test_connection_limit finished (2)
[task 2022-08-17T11:09:38.259Z] 11:09:38     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (1)
[task 2022-08-17T11:09:38.259Z] 11:09:38     INFO -  exiting test
[task 2022-08-17T11:09:38.259Z] 11:09:38     INFO -  <<<<<<<
[task 2022-08-17T11:09:38.427Z] 11:09:38     INFO -  xpcshell return code: 1
[task 2022-08-17T11:09:38.449Z] 11:09:38     INFO -  TEST-START | netwerk/test/unit/test_h2proxy_connection_limit.js

:kershaw, since you are the author of the regressor, bug 1772212, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(kershaw)

Set release status flags based on info from the regressing bug 1772212

Set release status flags based on info from the regressing bug 1772212

Summary: Intermittent TV TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_h2proxy_connection_limit.js | Test timed out → Intermittent TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_h2proxy_connection_limit.js | Test timed out
Flags: needinfo?(valentin.gosu)
Summary: Intermittent TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_h2proxy_connection_limit.js | Test timed out → High frequency TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_h2proxy_connection_limit.js | Test timed out
Assignee: nobody → valentin.gosu
Flags: needinfo?(valentin.gosu)
Flags: needinfo?(kershaw)
Priority: -- → P1
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][necko-triaged]

The test is fairly easy to reproduce in --verify mode under windows.
It seems the connection just hangs if we close the stream with NGHTTP2_CONNECT_ERROR here.

We take that code path because when the socket connected, we respond with a 200 status, then attempting to respond with a 404/502 would throw and close with that error.
For now I'm just going to bypass this problem by checking if we'd already sent the headers, but as a followup we should probably exercise the code path where Firefox receives NGHTTP2_CONNECT_ERROR (but in a deterministic manner).

(verify) by not throwing in HTTP2ProxyCode r=#necko

The patch also removes some redundant code from the test and
fixes a lint error in head_servers.js

Attachment #9292699 - Attachment description: WIP: Bug 1785239 - Fix failures in test_h2proxy_connection_limit.js → Bug 1785239 - Fix failures in test_h2proxy_connection_limit.js (verify) by not throwing in HTTP2ProxyCode r=#necko
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9c833f499833 Fix failures in test_h2proxy_connection_limit.js (verify) by not throwing in HTTP2ProxyCode r=necko-reviewers,kershaw
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: