Closed Bug 1785277 Opened 2 years ago Closed 2 years ago

Add source actor information to the location

Categories

(DevTools :: Debugger, enhancement)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

Details

Attachments

(1 file, 3 obsolete files)

Bug 1785277 - [devtools] Add sourceActorId to location r=ochameau
(deleted), text/x-phabricator-request
Details

Lets start tracking source actor id as part of the location information here https://searchfox.org/mozilla-central/rev/f3616b887b8627d8ad841bb1a11138ed658206c5/devtools/client/debugger/src/utils/location.js#12-22. This will help with tracking the specific source actor which loads the source text when a location is selected. A source can have multiple source actors, at the moment the is no guarantee that the correct source actor is selected. The https://searchfox.org/mozilla-central/rev/f3616b887b8627d8ad841bb1a11138ed658206c5/devtools/client/debugger/test/mochitest/browser_dbg-features-source-text-content.js covers this issue.

Attached file Bug 1785277 - Load source text with source actor r= (obsolete) (deleted) —
Attached file Bug 1785277 - Use source actor select location (WIP) (obsolete) (deleted) —

Depends on D154778

Attachment #9290415 - Attachment description: Bug 1785277 - Also use source actor for location selection r= → Bug 1785277 - Load source text with source actor r=

Depends on D154778

Comment on attachment 9290415 [details]
Bug 1785277 - Load source text with source actor r=

Revision D154778 was moved to bug 1787198. Setting attachment 9290415 [details] to obsolete.

Attachment #9290415 - Attachment is obsolete: true
Summary: Add source actor infomation to the location → Add source actor information to the location
Attachment #9290608 - Attachment is obsolete: true
Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Attachment #9292211 - Attachment description: Bug 1785277 - [devtools] Add sourceActorId to location → Bug 1785277 - [devtools] Add sourceActorId to location r=ochameau

Depends on D155952

Attachment #9295786 - Attachment is obsolete: true
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7cdb0cf84b6 [devtools] Add sourceActorId to location r=ochameau

https://hg.mozilla.org/mozilla-central/rev/b7cdb0cf84b6

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Backed out changeset b7cdb0cf84b6 (Bug 1785277) for causing devtools failures on browser_dbg-quick-open.js.
Backout link
Push with failures
Failure Log

Flags: needinfo?(hmanilla)
Status: RESOLVED → REOPENED
status-firefox108: fixed → ---
Resolution: FIXED → ---
Target Milestone: 108 Branch → ---
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1982cee06ca [devtools] Add sourceActorId to location r=ochameau

https://hg.mozilla.org/mozilla-central/rev/d1982cee06ca

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Flags: needinfo?(hmanilla)

== Change summary for alert #35745 (as of Tue, 25 Oct 2022 16:09:31 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
65% damp custom.jsdebugger.project-search.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 909.23 -> 1,504.61
63% damp custom.jsdebugger.project-search.DAMP windows10-64-shippable-qr e10s fission stylo webrender 934.05 -> 1,525.95
61% damp custom.jsdebugger.project-search.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 1,028.35 -> 1,654.38
60% damp custom.jsdebugger.project-search.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 1,021.36 -> 1,633.52
52% damp custom.jsdebugger.project-search.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 937.62 -> 1,420.65
51% damp custom.jsdebugger.project-search.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 992.63 -> 1,498.82
40% damp custom.jsdebugger.stepOver.DAMP windows10-64-shippable-qr e10s fission stylo webrender 277.76 -> 389.27
29% damp custom.jsdebugger.stepOver.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 288.55 -> 372.13
25% damp custom.jsdebugger.stepOver.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 356.48 -> 447.25
23% damp browser-toolbox.debugger-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 815.24 -> 1,005.76
... ... ... ... ...
6% damp custom.jsdebugger.stepOut.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 535.29 -> 567.42
5% damp custom.jsdebugger.stepOut.DAMP windows10-64-shippable-qr e10s fission stylo webrender 462.82 -> 483.99
4% damp browser-toolbox.webconsole-ready.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 422.56 -> 439.70
4% damp custom.jsdebugger.stepOut.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 463.97 -> 482.40
4% damp custom.jsdebugger.stepIn.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 637.93 -> 661.26

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35745

Hubert, Alex, do we want to investigate/fix the regression detected by DAMP for this change (see previous comment)? If yes, can you file a follow up?

Flags: needinfo?(poirot.alex)
Flags: needinfo?(hmanilla)

Oh thanks,
This might relate to now always getting the source actor anytime we need to load the source text.
There are likely going to regressions with moving to breakpoints per url, but maybe i can improve this a little bit here e.g The source is always selected again using the id where instead we could just pass the source in directly here. Maybe that helps, i'll check and file

Flags: needinfo?(hmanilla)
Flags: needinfo?(hmanilla)

The regressions around custom.jsdebugger.project-search are concerning and should be investigated.
We might have significantly slow down file search, which is a nice thing being fast in firefox (while being super slow in chrome).

Flags: needinfo?(poirot.alex)
Regressions: 1798775
Flags: needinfo?(hmanilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: