Closed Bug 1786427 Opened 2 years ago Closed 2 years ago

Intermittent browser/components/urlbar/tests/browser/browser_quickactions.js | single tracking bug

Categories

(Firefox :: Address Bar, defect, P5)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- unaffected
firefox105 --- unaffected
firefox106 --- wontfix
firefox107 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: daisuke)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disabled])

Attachments

(3 files)

Bug 1786427 - disable browser_quickactions.js on mac and win opt r?#intermittent-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1786427: Extract tab refocus tests to a separate file.
(deleted), text/x-phabricator-request
Details
Bug 1786427: Extract inspector tests to a separate file.
(deleted), text/x-phabricator-request
Details

Filed by: mlaza [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=388126986&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZHGp9fyVSXCf1-klaT9x1w/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZHGp9fyVSXCf1-klaT9x1w/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2022-08-22T21:35:18.761Z] 21:35:18     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quickactions.js | The command "themes" passed completed its test - true == true - 
[task 2022-08-22T21:35:18.761Z] 21:35:18     INFO - Leaving test bound test_pages
[task 2022-08-22T21:35:18.761Z] 21:35:18     INFO - Buffered messages finished
[task 2022-08-22T21:35:18.761Z] 21:35:18     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_quickactions.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2022-08-22T21:35:18.762Z] 21:35:18     INFO - GECKO(1540) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2022-08-22T21:35:18.762Z] 21:35:18     INFO - GECKO(1540) | MEMORY STAT | vsize 16012MB | residentFast 318MB | heapAllocated 149MB
[task 2022-08-22T21:35:18.763Z] 21:35:18     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_quickactions.js | took 46260ms

:daleharvey, since you are the author of the regressor, bug 1783152, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(dharvey)

Set release status flags based on info from the regressing bug 1783152

status-firefox104: --- → unaffected
status-firefox105: --- → unaffected
status-firefox106: --- → affected
status-firefox-esr102: --- → unaffected
status-firefox-esr91: --- → unaffected
Summary: Intermittent TV [tier 2] browser/components/urlbar/tests/browser/browser_quickactions.js | single tracking bug → Intermittent browser/components/urlbar/tests/browser/browser_quickactions.js | single tracking bug
Assignee: nobody → dharvey
Flags: needinfo?(dharvey)

There have been 52 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • macosx1015-64-qr
  • macosx1015-64-shippable-qr
  • windows10-32-2004-qr
  • windows10-64-2004-shippable-qr
Whiteboard: [stockwell needswork:owner]
Keywords: leave-open
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][stockwell disabled]
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81fb44f0231e disable browser_quickactions.js on mac and win opt r=intermittent-reviewers,jmaher DONTBUILD

Hey Daisuke, it looks like these failres are from opening the devtools, I can / am taking a look but pinging in case you already know whats up. Cheers

Flags: needinfo?(daisuke)

Hi Dale!

I investigated which tests take time in my local.

  • basic:174 ms
  • test_label_command:77
  • enter_search_mode_button:157
  • enter_search_mode_key:105
  • test_disabled:83
  • test_screenshot_disabled:87
  • match_in_phrase:76
  • test_screenshot:138
  • test_other_search_mode:53
  • test_no_quickactions_suggestions:163
  • test_quickactions_disabled:175
  • test_pages:4526
  • test_about_pages_refocused:7356
  • test_about_addons_pages_refocused:2923
  • test_inspector:2252
  • test_viewsource:597
  • test_refresh:140
  • test_clear:134
  • test_update:150
  • test_show_in_zero_prefix:116
  • test_whitespace:213

As the above results, it seems that the following tests take time especially.

  • test_about_pages_refocused: 7356,
  • test_about_addons_pages_refocused:2923,
  • test_inspector:2252

It seems that it take time for tests opening new tab. (test_inspector is by another reason though)
If we can reuse tabs for above tests, it might be able to reduce the time.
If you don’t mind, may I take a look at this one?

Flags: needinfo?(daisuke)

Sure feel free to assign yourself. The test file is already getting quite long so it would probably be a good idea to split it out into seperate files if the problem is the runtime of the tests and the alternative is doing something complicated

Okay. I will extract the tests for refocusing to a separate file.

Assignee: dharvey → daisuke
Status: NEW → ASSIGNED
Whiteboard: [stockwell disabled][stockwell unknown] → [stockwell disabled]

Depends on D158181

Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57574d06d256 Extract tab refocus tests to a separate file. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/c01a94293432 Extract inspector tests to a separate file. r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: leave-open
Resolution: --- → FIXED
status-firefox107: --- → fixed
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: