Hide Inspect (DevTools) action button if DevTools is fully disabled
Categories
(Firefox :: Address Bar, enhancement)
Tracking
()
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
Attachments
(2 files)
This is a follow-up for bug 1783877.
As Julian suggested in phabricator, may be better to hide Inspect action button completely instead of disabling, if DevTools is fully disabled.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D156247
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f62b95d76d4d
https://hg.mozilla.org/mozilla-central/rev/99e0920487ff
|
||
Comment 5•2 years ago
|
||
Hello Daisuke,
I've tested this using the latest nightly (Fx107.0a1) on Windows and Ubuntu, but the 'inspector' button is still visible.
I've set 'devtools.policy.disabled' to true and the in the address bar I've typed 'insp' and the quick-actions button showed up, but it was disabled. Was this patch supposed to disable it or hide it completely?
|
|
Assignee | |
Comment 6•2 years ago
|
||
Hello Cristian, thank you very much for your comment!
Well, we need to set one more pref devtools.selfxss.count to 0 to disable DevTools completely.
https://searchfox.org/mozilla-central/rev/ffa4d00965c5281def6d3ddcbcdf6259d38c9b9a/devtools/startup/DevToolsStartup.sys.mjs#674-683
|
|
||
Comment 7•2 years ago
|
||
The issue is verified fixed using the latest Fx107.0a1 on Windows 10 and Ubuntu 22.04. When setting devtools.selfxss.count to 0 and devtools.policy.disabled to true the Inspect quickaction button is no longer visible.
Description
•