Closed Bug 1788032 Opened 2 years ago Closed 2 years ago

Convert devtools/client JSMs to ES Modules

Categories

(DevTools :: General, task)

Product:
DevTools
Component:
General
Type:
task

Tracking

(firefox106 fixed)

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: [esmification-timeline])

Attachments

(2 files, 1 obsolete file)

Bug 1788032 - [devtools] Remove unused AbstractTreeItem.jsm.
(deleted), text/x-phabricator-request
Details
Bug 1788032 - [devtools] Convert devtools/client JSM to ES Modules.
(deleted), text/x-phabricator-request
Details

It looks like all devtools/client JSMs could easily be converted to ES Modules all at once:
devtools/client/framework/browser-toolbox/Launcher.jsm (done in bug 1783821)
devtools/client/jsonview/Converter.jsm
devtools/client/jsonview/Sniffer.jsm
devtools/client/shared/widgets/AbstractTreeItem.jsm (unused)
devtools/client/storage/VariablesView.jsm
devtools/client/styleeditor/StyleEditorUI.jsm
devtools/client/styleeditor/StyleEditorUtil.jsm
devtools/client/styleeditor/StyleSheetEditor.jsm
The three last will allow to close bug 1242987.

Whiteboard: [esmification-timeline]
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

This is the result of:
$ ./mach esmify devtools/client/

Attached file Bug 1788032 - [devtools] Manuel eslint fixes. (obsolete) (deleted) —

We are having a few disabling of eslint rules specific to jsm.
Let's try to narrow down more precise disablings
and fix a few small issues.

Attachment #9292642 - Attachment is obsolete: true
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4b92cb2f06fc [devtools] Remove unused AbstractTreeItem.jsm. r=bomsy https://hg.mozilla.org/integration/autoland/rev/46aac0431a69 [devtools] Convert devtools/client JSM to ES Modules. r=bomsy

https://hg.mozilla.org/mozilla-central/rev/4b92cb2f06fc
https://hg.mozilla.org/mozilla-central/rev/46aac0431a69

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Regressions: 1808993
Depends on: 1808993
No longer regressions: 1808993
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: