Closed Bug 1788152 Opened 2 years ago Closed 2 years ago

Firefox View: Empty state when no Recently Closed / Synced Tabs are available

Categories

(Firefox :: Firefox View, enhancement, P3)

Desktop
All
enhancement
Points:
5

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox106 --- wontfix
firefox107 --- wontfix
firefox108 --- fixed

People

(Reporter: meridel, Assigned: kcochrane)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(4 files)

Actual: When no "Recently closed" tabs are available in that section, we display a line of body copy that reads: "Never fear losing a closed tab again. You can always retrieve it here."

Recommendation: I don't recall reviewing this copy (and the content designer who led this work has since left Mozilla) but it should be removed or revised. The tone isn't quite right ("Never fear...") and it's not actionable or necessary. It also has inconsistent terminology (pages/tabs). Phil Bothun from Content Design can provide a recommendation.

Summary: Firefox View → Firefox View: Empty state body copy string when no Recently Closed Tabs are available
Component: General → Firefox View

The string comes from bug 1780855

New strings from copy approved. Please replace current state with new strings.

It would be nice to understand where things went wrong, because this type of situations creates churn for localization.

Component: Firefox View → General
Flags: needinfo?(pbothun)

Hi Flod, if we can't fix copy issues like this before September 15, that's okay. This is not a usability issue — it's a quality issue. Phil will log what he sees and PM help triage.

Why this happened is a larger topic for postmortem and has to do with staffing shortages.

(In reply to Meridel [:meridel] from comment #3)

Aha, I found what this string SHOULD be: https://docs.google.com/presentation/d/1o42c8iY8jOTWjjvCbrbIYz7IDisnfcqxxB_Z_qigRw0/edit#slide=id.g12cb23bc0a4_0_10

That string landed originally and was replaced in the bug I linked to. It's more evident here
https://hg.mozilla.org/mozilla-central/rev/1640d9d855e0

Noted, thank you. I do think these strings could be stronger. We don't need to fix now but if we have time we should improve it.

Severity: -- → S4
Priority: -- → P3
Flags: needinfo?(pbothun)
Depends on: 1780855

Phil -- Can you provide a recommendation here? We can table the fix for post MR in order to avoid complexities related to l10n. But I'd like to align on the improved messaging if we can ahead of time.

Flags: needinfo?(pbothun)

Hey Ray, I pinged you in the Figma, but here's a link to the Figma page as well: https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=10391%3A140687. Change is pending copy second set of eyes and localization feedback as well, but I'd like your thoughts before I go down one direction too far.

Flags: needinfo?(pbothun)

This looks good to me Phil. Flod and Josh are also OK with it.

(In reply to pbothun from comment #7)

Hey Ray, I pinged you in the Figma, but here's a link to the Figma page as well: https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=10391%3A140687. Change is pending copy second set of eyes and localization feedback as well, but I'd like your thoughts before I go down one direction too far.

So this bug is just listed as copy but the figma also has illustrations. Is the idea that in this bug we'll just update copy, and the illustrations happen elsewhere?

(I have some concerns about the orange in the illustrations and how they would respond to different backgrounds ie themes/colourways.)

For Phil: I am not a copywriter, and not even technically a native English speaker - but I was confused by the phrasing for recently closed tabs string. I thought it was "place before time" in English, so expected it should be "... from here anytime." I'm probably missing something...

(it also seems the mocks are still marked "in progress" on figma, with two variations of illustrations - are there more updates to come or are they ready for engineering?)

Flags: needinfo?(rfambro)
Flags: needinfo?(pbothun)

@Gijs -- The illustrations were going to be added as part of the fast-follow work as we didn't receive them in time to meet the 106 deadline. (Jira Story here -- https://mozilla-hub.atlassian.net/browse/FIDE-847). To your point though, we'd likely want to do an a11y/contrast review to ensure that there are no issues.

@Josh -- Can you confirm which illustration option is the desired one?

Flags: needinfo?(rfambro) → needinfo?(jberman)

@Ray @Gijs - this is the latest illustration. https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=10568%3A137663

I will double check color will work and consult with some of my more visually oriented teammates on optimal colors for light and dark mode.

Flags: needinfo?(jberman)

@Gijs, if I cut out the "anytime" and make the string "When you close a tab in this window, you can retrieve it anytime from here." would that fix what you're talking about?

Flags: needinfo?(pbothun)

(In reply to pbothun from comment #12)

@Gijs, if I cut out the "anytime" and make the string "When you close a tab in this window, you can retrieve it anytime from here." would that fix what you're talking about?

Yep, that makes sense to me.

(In reply to Josh Berman from comment #11)

@Ray @Gijs - this is the latest illustration. https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=10568%3A137663

I will double check color will work and consult with some of my more visually oriented teammates on optimal colors for light and dark mode.

Thanks Josh! Can you let us know when this is ready for engineering?

Flags: needinfo?(jberman)

Sounds good! Alright if I aim for like mid next week? Wednesday or so?

(In reply to Josh Berman from comment #14)

Sounds good! Alright if I aim for like mid next week? Wednesday or so?

Yep, that should be fine. I'm out until that Thursday/Friday anyway. :-)

Figma file with approved empty state illustrations. You'll find dark mode illustrations there as well. These illustrations are decorative elements, and I suggest we give them a null value and no alt text so screen readers entirely skip them.

https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=10391%3A140687

Flags: needinfo?(jberman)
Blocks: 1788692
Flags: needinfo?(gijskruitbosch+bugs)

Meridel, just to confirm copy here has been signed off? :-)

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mwalkington)

The Figma file from Josh above still has the 'anytime' word in it, and I left a comment with a minor suggestion (that just came to me and can be set aside if it causes localization issues).

https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=10391%3A140687

Flags: needinfo?(mwalkington) → needinfo?(pbothun)
Type: defect → enhancement
Summary: Firefox View: Empty state body copy string when no Recently Closed Tabs are available → Firefox View: Empty state when no Recently Closed / Synced Tabs are available

It seems there is now a second figma mockup (which has illustrations as well). This already has the anytime bit removed. Phil, can you update this ticket with the resolution of the discussion with Meridel about the other thing her comment's referring to when that happens? Thanks!

Component: General → Firefox View

(In reply to :Gijs (he/him) from comment #19)

It seems there is now a second figma mockup (which has illustrations as well). This already has the anytime bit removed. Phil, can you update this ticket with the resolution of the discussion with Meridel about the other thing her comment's referring to when that happens? Thanks!

Final string:
Headline: No recently closed tabs
Body: When you close a tab in this window, you can fetch it from here.

Flags: needinfo?(pbothun)
Blocks: 1797520
No longer blocks: firefox-view, 1788692
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED

Josh, how should we treat the illustration when using a darker colorways theme where the container has a background color? I've attached example screenshots of the light and dark versions of the illustration on the Bold 'Dreamer' colorways theme for reference.

Flags: needinfo?(jberman)

What if we just increase the opacity of that background color a bit? Here I bumped it from 7% to 15%. I think that should work. It doesnt need to pass contrast (it's purely aesthetic) but it should be about the same amount of visible as the light illustration type on a white background.

https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=13372%3A150969

Flags: needinfo?(jberman)

That works for me! Thanks, Josh.

Kelly, can you please update the bug and corresponding JIRA ticket with story points?

Flags: needinfo?(kcochrane)
Points: --- → 5
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d31a48e25bd Update presentation of Recently Closed and Tab Pickup empty states r=flod,fluent-reviewers,desktop-theme-reviewers,sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

There are string changes so we can't uplift.

Regressions: 1799671
QA Whiteboard: [qa-108b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: