Use background task for QuotaManager shutdown cleanup
Categories
(Core :: Storage: Quota Manager, enhancement)
Tracking
()
People
(Reporter: saschanaz, Assigned: saschanaz)
References
(Blocks 4 open bugs)
Details
Attachments
(5 files, 3 obsolete files)
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
There are 10+ separate macro definition for this, we can do it globally instead.
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
This background task currently is generic enough that it can be reused for other components, namely QuotaCleaner in the child patches. Renaming makes it clear that it's generic.
Depends on D156911
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D156331
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D156939
Assignee | ||
Comment 6•2 years ago
|
||
Depends on D156940
Comment 7•2 years ago
|
||
Comment on attachment 9293841 [details]
Bug 1788986 - Part 1: Define MOZ_BACKGROUNDTASKS macro globally r=janv,smaug
Revision D156911 was moved to bug 1796085. Setting attachment 9293841 [details] to obsolete.
Comment 8•2 years ago
|
||
Comment on attachment 9293842 [details]
Bug 1788986 - Part 2: Rename _purgeHTTPCache as _removeDirectory r=valentin
Revision D156912 was moved to bug 1796085. Setting attachment 9293842 [details] to obsolete.
Assignee | ||
Comment 9•2 years ago
|
||
Depends on D157757
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Comment 11•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 13•2 years ago
|
||
Comment 14•2 years ago
|
||
Comment on attachment 9306925 [details]
data review request.md
load-balancing and taking data reivew for :chutten
Comment 15•2 years ago
|
||
Comment on attachment 9306925 [details]
data review request.md
Data Review
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, through the metrics.yaml file and the Glean Dictionary.
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, through the telemetry data preferences in the application settings.
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Permanent collection to be monitored by Kagami Rosylight
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1, Technical data
- Is the data collection request for default-on or default-off?
Default-on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does the data collection use a third-party collection tool?
No
Result
data-review+
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 16•2 years ago
|
||
Hi :chutten, given we have both data-review and glean bug, can you take another look at https://phabricator.services.mozilla.com/D156941 ?
Side note: The patch does not send any telemetry when the background task times out. For now we are okay with that.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 17•2 years ago
|
||
Comment 18•2 years ago
|
||
Backed out for causing xpcshell failures on test_backgroundtask_removeDirectory.js.
[task 2023-02-02T19:15:07.062Z] 19:15:07 INFO - TEST-START | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js
[task 2023-02-02T19:15:10.402Z] 19:15:10 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | xpcshell return code: 0
[task 2023-02-02T19:15:10.402Z] 19:15:10 INFO - TEST-INFO took 3337ms
[task 2023-02-02T19:15:10.402Z] 19:15:10 INFO - >>>>>>>
[task 2023-02-02T19:15:10.402Z] 19:15:10 INFO - PID 25514 | [Parent 25514, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2908
[task 2023-02-02T19:15:10.402Z] 19:15:10 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - running event loop
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | Starting test_simple
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - (xpcshell/head.js) | test test_simple pending (2)
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - TEST-PASS | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | test_simple - [test_simple : 23] true == true
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - TEST-PASS | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | test_simple - [test_simple : 28] true == true
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - TEST-PASS | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | test_simple - [test_simple : 52] resource://testing-common is not substituted - true == true
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - PID 25514 | console.info: "launching background task" ({command:"/builds/worker/workspace/build/application/firefox/firefox-bin", args:["--backgroundtask", "removeDirectory", "/tmp/xpc-profile-7vny_2xo", "newCacheFolder", "10", ".abc"], extraEnv:{XPCSHELL_TESTING_MODULES_URI:"file:///builds/worker/workspace/build/tests/modules/"}})
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - PID 25514 | 25533> *** You are running in background task mode. ***
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - PID 25514 | 25533> *** You are running in headless mode.
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - PID 25514 | 25533> [25533, Main Thread] WARNING: ShouldNotProcessUpdates(): NotAnUpdatingTask: file /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:4501
[task 2023-02-02T19:15:10.403Z] 19:15:10 INFO - PID 25514 | 25533> [25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.404Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.404Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.409Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.410Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.410Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.410Z] 19:15:10 INFO - PID 25514 | 25533> console.error: BackgroundTasksManager:
[task 2023-02-02T19:15:10.411Z] 19:15:10 INFO - PID 25514 | 25533> Substitution set: resource://testing-common aliases file:///builds/worker/workspace/build/tests/modules/
[task 2023-02-02T19:15:10.411Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/js/xpconnect/loader/mozJSModuleLoader.cpp:694
[task 2023-02-02T19:15:10.412Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/js/loader/ModuleLoaderBase.cpp:416
[task 2023-02-02T19:15:10.412Z] 19:15:10 INFO - PID 25514 | 25533> console.error: "/tmp/xpc-profile-7vny_2xo" "newCacheFolder" 10 ".abc" ""
[task 2023-02-02T19:15:10.413Z] 19:15:10 INFO - PID 25514 | 25533> console.error: "started removing /tmp/xpc-profile-7vny_2xo/newCacheFolder"
[task 2023-02-02T19:15:10.413Z] 19:15:10 INFO - PID 25514 | 25533> console.error: "done removing /tmp/xpc-profile-7vny_2xo/newCacheFolder. removed 1 entries."
[task 2023-02-02T19:15:10.414Z] 19:15:10 INFO - PID 25514 | 25533> console.error: "Deletion of folder test.abc - success=true"
[task 2023-02-02T19:15:10.414Z] 19:15:10 INFO - PID 25514 | 25533> console.warn: "Skipping Glean as no metrics id is passed"
[task 2023-02-02T19:15:10.414Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3384
[task 2023-02-02T19:15:10.415Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3376
[task 2023-02-02T19:15:10.415Z] 19:15:10 INFO - PID 25514 | 25533> [Parent 25533, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4663
[task 2023-02-02T19:15:10.416Z] 19:15:10 INFO - TEST-PASS | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | test_simple - [test_simple : 33] 0 == 0
[task 2023-02-02T19:15:10.416Z] 19:15:10 INFO - TEST-PASS | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | test_simple - [test_simple : 34] false == false
<...>
[task 2023-02-02T19:15:10.489Z] 19:15:10 INFO - TEST-PASS | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | test_purgeFile - [test_purgeFile : 52] resource://testing-common is not substituted - true == true
[task 2023-02-02T19:15:10.490Z] 19:15:10 INFO - PID 25514 | console.info: "launching background task" ({command:"/builds/worker/workspace/build/application/firefox/firefox-bin", args:["--backgroundtask", "removeDirectory", "/tmp/xpc-profile-7vny_2xo", "newCacheFolder", "2", ""], extraEnv:{XPCSHELL_TESTING_MODULES_URI:"file:///builds/worker/workspace/build/tests/modules/"}})
[task 2023-02-02T19:15:10.490Z] 19:15:10 INFO - (xpcshell/head.js) | test run_next_test 6 finished (2)
[task 2023-02-02T19:15:10.490Z] 19:15:10 INFO - PID 25514 | 25668> *** You are running in background task mode. ***
[task 2023-02-02T19:15:10.491Z] 19:15:10 INFO - PID 25514 | 25668> *** You are running in headless mode.
[task 2023-02-02T19:15:10.491Z] 19:15:10 INFO - PID 25514 | 25668> [25668, Main Thread] WARNING: ShouldNotProcessUpdates(): NotAnUpdatingTask: file /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:4501
[task 2023-02-02T19:15:10.491Z] 19:15:10 INFO - PID 25514 | 25668> [25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.492Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.492Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.493Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.493Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.494Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:478
[task 2023-02-02T19:15:10.494Z] 19:15:10 INFO - PID 25514 | 25668> console.error: BackgroundTasksManager:
[task 2023-02-02T19:15:10.495Z] 19:15:10 INFO - PID 25514 | 25668> Substitution set: resource://testing-common aliases file:///builds/worker/workspace/build/tests/modules/
[task 2023-02-02T19:15:10.495Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/js/xpconnect/loader/mozJSModuleLoader.cpp:694
[task 2023-02-02T19:15:10.495Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/js/loader/ModuleLoaderBase.cpp:416
[task 2023-02-02T19:15:10.496Z] 19:15:10 INFO - PID 25514 | 25668> console.error: "/tmp/xpc-profile-7vny_2xo" "newCacheFolder" 2 "" ""
[task 2023-02-02T19:15:10.496Z] 19:15:10 INFO - PID 25514 | 25668> console.warn: "Skipping Glean as no metrics id is passed"
[task 2023-02-02T19:15:10.497Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3384
[task 2023-02-02T19:15:10.497Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3376
[task 2023-02-02T19:15:10.498Z] 19:15:10 INFO - PID 25514 | 25668> [Parent 25668, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4663
[task 2023-02-02T19:15:10.498Z] 19:15:10 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js | test_purgeFile - [test_purgeFile : 150] 0 == 3
[task 2023-02-02T19:15:10.499Z] 19:15:10 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js:test_purgeFile:150
[task 2023-02-02T19:15:10.499Z] 19:15:10 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:238
[task 2023-02-02T19:15:10.499Z] 19:15:10 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:585
[task 2023-02-02T19:15:10.500Z] 19:15:10 INFO - -e:null:1
[task 2023-02-02T19:15:10.500Z] 19:15:10 INFO - exiting test
[task 2023-02-02T19:15:10.500Z] 19:15:10 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2023-02-02T19:15:10.501Z] 19:15:10 INFO - _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:863:20
[task 2023-02-02T19:15:10.501Z] 19:15:10 INFO - do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:964:5
[task 2023-02-02T19:15:10.501Z] 19:15:10 INFO - Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:71:21
[task 2023-02-02T19:15:10.502Z] 19:15:10 INFO - Assert.prototype.report@resource://testing-common/Assert.sys.mjs:240:10
[task 2023-02-02T19:15:10.502Z] 19:15:10 INFO - equal@resource://testing-common/Assert.sys.mjs:282:8
[task 2023-02-02T19:15:10.502Z] 19:15:10 INFO - test_purgeFile@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_removeDirectory.js:150:8
[task 2023-02-02T19:15:10.503Z] 19:15:10 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:238:6
[task 2023-02-02T19:15:10.503Z] 19:15:10 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:585:5
[task 2023-02-02T19:15:10.504Z] 19:15:10 INFO - @-e:1:1
[task 2023-02-02T19:15:10.504Z] 19:15:10 INFO - exiting test
[task 2023-02-02T19:15:10.505Z] 19:15:10 INFO - PID 25514 | [Parent 25514, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3384
[task 2023-02-02T19:15:10.506Z] 19:15:10 INFO - PID 25514 | [Parent 25514, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3376
[task 2023-02-02T19:15:10.506Z] 19:15:10 INFO - PID 25514 | [Parent 25514, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4663
[task 2023-02-02T19:15:10.507Z] 19:15:10 INFO - PID 25514 | [Parent 25514, Main Thread] WARNING: XPCOM object PerThreadData destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:215
[task 2023-02-02T19:15:10.507Z] 19:15:10 INFO - PID 25514 | [Parent 25514, Main Thread] WARNING: XPCOM object SourceList destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:215
[task 2023-02-02T19:15:10.508Z] 19:15:10 INFO - <<<<<<<
[task 2023-02-02T19:15:10.508Z] 19:15:10 INFO - TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_dnr_dynamic_rules.js
Assignee | ||
Updated•2 years ago
|
Comment 19•2 years ago
|
||
Comment 20•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c94ac408f1d2
https://hg.mozilla.org/mozilla-central/rev/2c029e015415
https://hg.mozilla.org/mozilla-central/rev/b6784be04a8b
Comment 21•2 years ago
|
||
Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Updated•2 years ago
|
Description
•