Dangerous Flag Constant Declaration in SelectionActionDelegate
Categories
(GeckoView :: General, task, P3)
Tracking
(firefox113 fixed)
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: m_kato, Assigned: nkitanand, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=java])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is lint warning issue by ./mach lint -l android-lint.
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:3427: Consider declaring this constant using 1 << 1 instead
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:3429: Consider declaring this constant using 1 << 2 instead
FLAG_IS_COLLAPSED, FLAG_IS_EDITABLE and FLAG_IS_PASSWORD should use shift such as 1 << 1.
|
||
Updated•2 years ago
|
|
Reporter | |
Updated•2 years ago
|
|
Assignee | |
Comment 2•2 years ago
|
||
I want to work on this issue as my first contribution.
|
|
Reporter | |
Comment 3•2 years ago
|
||
(In reply to Ankit Anand from comment #2)
I want to work on this issue as my first contribution.
Welcome. Contribution document is https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/index.html and https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch. And we have a chat room in https://chat.mozilla.org/#/room/#introduction:mozilla.org for new contributor.
Also, https://bugzilla.mozilla.org/show_bug.cgi?id=1510613 was similar issue.
|
|
Reporter | |
Updated•2 years ago
|
|
||
Comment 4•2 years ago
|
||
Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)
|
|
Reporter | |
Comment 5•2 years ago
|
||
(In reply to Tal from comment #4)
Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)
Welcome. :nkitanand doesn't seem to work on this now since no action after that. See comment #3 for contribution.
|
|
Assignee | |
Comment 6•2 years ago
|
||
(In reply to Tal from comment #4)
Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)
Hey Tal,
I am still working on this issue. I have put too much effort and time into it. Please let me work on it.
|
|
||
Comment 7•2 years ago
|
||
(In reply to Ankit Anand from comment #6)
(In reply to Tal from comment #4)
Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)
Hey Tal,
I am still working on this issue. I have put too much effort and time into it. Please let me work on it.
Of course, I'm so sorry about that! Best of luck!
|
|
Assignee | |
Comment 8•2 years ago
|
||
Changed flag constant declaration to use shift operator rather than
simple assignment as per the coding conventions.
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
Description
•