When a primary password is enabled, it is expected that Sync will cause prompt to be shown as the browser starts, and it's also expected a prompt will be shown each time the user selects "Sync Now".

However, it's not expected that any interaction with "sync tabs" (such as showing the "account" submenu) will cause a prompt to be shown - but it does.

Attaching a patch that ensures we only attempt to sync tabs when the login state is "ok" - other login related errors (such as an FxA auth error, or that the primary password is locked) causes us to decline syncing.

Automated testing for this is difficult as none of our tests use a real sync status, so the best we could do is mock sync to pretend to be in the very state we are explicitly testing for, but that doesn't seem particularly valuable.

I believe this will largely fix bug 1787619. WWe might need some followup so that the UI can show something appropriate when in this state, but this patch should not regress anything - all UI will show the same state now as when the user cancelled the main prompt.

(In reply to Mark Hammond [:markh] [:mhammond] from comment #0)

but this patch should not regress anything - all UI will show the same state now as when the user cancelled the main prompt.

Actually, I should clarify - this does cause a behavior change - previously, calls to syncTabs() would fail. This patch just returns success, the same way it already does if sync isn't configured.

https://hg.mozilla.org/mozilla-central/rev/850165f95d18

Confirmed as verified-fixed in 106.0b5 Firefox.