Closed
Bug 1789511
Opened 2 years ago
Closed 2 years ago
[rust 1.64] error: unused return value of `Box::<T>::from_raw` that must be used
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - error: unused return value of `Box::<T>::from_raw` that must be used
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - --> netwerk/base/mozurl/src/lib.rs:131:9
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - |
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - 131 | Box::from_raw(url as *const MozURL as *mut MozURL);
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - |
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - = note: `-D unused-must-use` implied by `-D warnings`
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - = note: call `drop(from_raw(ptr))` if you intend to drop the `Box`
[task 2022-09-06T21:42:19.142Z] 21:42:19 INFO - error: could not compile `mozurl` due to previous error
|
Assignee | |
Comment 1•2 years ago
|
||
Also:
[task 2022-09-06T22:47:00.310Z] 22:47:00 INFO - error: unused return value of `Box::<T>::from_raw` that must be used
[task 2022-09-06T22:47:00.310Z] 22:47:00 INFO - --> netwerk/socket/neqo_glue/src/lib.rs:200:9
[task 2022-09-06T22:47:00.310Z] 22:47:00 INFO - |
[task 2022-09-06T22:47:00.310Z] 22:47:00 INFO - 200 | Box::from_raw(conn as *const _ as *mut NeqoHttp3Conn);
[task 2022-09-06T22:47:00.310Z] 22:47:00 INFO - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2022-09-06T22:47:00.310Z] 22:47:00 INFO - |
[task 2022-09-06T22:47:00.310Z] 22:47:00 INFO - = note: `-D unused-must-use` implied by `-D warnings`
[task 2022-09-06T22:47:00.311Z] 22:47:00 INFO - = note: call `drop(from_raw(ptr))` if you intend to drop the `Box`
[task 2022-09-06T22:47:00.311Z] 22:47:00 INFO - error: could not compile `neqo_glue` due to previous error
|
|
Assignee | |
Comment 2•2 years ago
|
||
As of rustc 1.64, Box::from_raw is #[must_use].
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/663615ef7a19
Use drop(Box::from_raw). r=necko-reviewers,dragana
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•