[Quickactions] Actions should be visible when using `>`, even if "Quick actions" is not enabled in preferences
Categories
(Firefox :: Address Bar, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox107 | --- | verified |
People
(Reporter: glob, Assigned: aminomancer)
References
Details
Attachments
(2 files)
STR
- Disable
Quick actions
via Preferences --> Address Bar - Confirm that actions are no longer visible in the address bar's dropdown
- Type
>
to start searching for actions
Expected
- address bar switched to searching for actions
- a filtered list of available actions
Actual
- address bar switched to searching for actions
- no actions are listed
Notes
browser.urlbar.suggest.quickactions
isfalse
browser.urlbar.shortcuts.quickactions
istrue
Assignee | ||
Comment 2•2 years ago
|
||
Some notes: If we add a new pref browser.urlbar.quickactions.enabled
, that can enable/disable the entire feature, while browser.urlbar.suggest.quickactions
will only determine whether quick action results are shown outside of the quick actions search mode.
browser.urlbar.shortcuts.quickactions
and browser.urlbar.quickactions.showPrefs
would remain unchanged, determining the display of the quick actions one-off search engine button and the checkbox in about:preferences, respectively.
The relevant code is here - we can change it to this:
isActive(queryContext) {
return (
lazy.UrlbarPrefs.get("quickactions.enabled") &&
((lazy.UrlbarPrefs.get("suggest.quickactions") && !queryContext.searchMode) ||
queryContext.searchMode.source == UrlbarUtils.RESULT_SOURCE.ACTIONS)
);
}
Assignee | ||
Comment 3•2 years ago
|
||
Change the behavior of the QuickActions provider, so that setting the
pref quickactions.enabled
to false will prevent showing quick action
results in all contexts, while setting suggest.quickactions
to false
will only prevent showing quick action results in the default search
mode (i.e., quick action results will still appear in the Quick Actions
search mode enabled by typing >
in the urlbar).
Updated•2 years ago
|
Comment 5•2 years ago
|
||
bugherder |
Comment 7•2 years ago
|
||
The issue is verified fixed using the latest Fx107.0a1 on Windows 10 and Ubuntu 22.04. The buttons are correctly shown in searchmode with the suggestions disabled.
Description
•