HCM: background images are not allowed in property with multiple backgrounds if one of the layers lacks a background image
Categories
(Core :: Layout, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | verified |
People
(Reporter: aminomancer, Assigned: emilio)
References
(Blocks 1 open bug, )
Details
(Keywords: access, testcase)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
(Tested on Windows 10 and macOS 12.5.1)
STR
- Make sure HCM is disabled
- Open this test case
- Click the lightning bolt a few times, see that the background color alternates between red and blue and the bolt remains visible
- Now set
browser.display.document_color_useto 2 - Go back to the test case - the red/blue background should no longer be visible, overridden by HCM
- Again, click the lightning bolt a few times
Expected
The bolt should remain visible
Actual
In HCM, the bolt disappears for the blue background mode. Looking at the changeBG function in the JS section, you can see the problem. It's replacing red with , blue which means an additional background layer. Since this layer has no image, the background-image in the first layer isn't honored, so we see no bolt in this state.
This affects the noodle images on the new MR about:welcome (browser.aboutwelcome.templateMR = true). I submitted a provisional patch for that issue (bug 1789667) which just consolidates the background-color and background-image into one layer, but it would still be worth fixing the underlying cause. I haven't done an exhaustive review of what else this may affect.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
Reporter | |
Comment 3•2 years ago
|
||
Nice! Thanks
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
|
||
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
Reproduced on build from 06.09.2022.
No longer reproducible on 106.0b4
|
||
Updated•1 year ago
|
Description
•